From patchwork Mon Jun 9 18:05:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 4323041 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B4611BEEAA for ; Mon, 9 Jun 2014 18:08:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D97EF20221 for ; Mon, 9 Jun 2014 18:08:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1777720204 for ; Mon, 9 Jun 2014 18:08:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wu3wr-0003Xs-PR; Mon, 09 Jun 2014 18:05:33 +0000 Received: from mail-pb0-x233.google.com ([2607:f8b0:400e:c01::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wu3wo-0003UW-Ep for linux-arm-kernel@lists.infradead.org; Mon, 09 Jun 2014 18:05:30 +0000 Received: by mail-pb0-f51.google.com with SMTP id ma3so5238857pbc.10 for ; Mon, 09 Jun 2014 11:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=yKmTqOiEW51/idmXKsVFLXr61QJa5tJp53FB7EywmnA=; b=uMeDjd8z9vgJROTAReEbqYP9/RcTcVKlD3TyNmFL2yzCUQo+EIOQvuEg2DS3ZBXKh5 J9FnJh79z9yiLja+yy0x/Yy4TzzhZEcld3QJQwK2u1neQ6X6n/9GUUMozdRPUmlB5hxK wgootCVGnfh0crmwjy2kPYfbTjh5ysyaqoDv10+SKX3joyqa1lt5eGos4d11rIvCWj7I JkwLlLM52CEU2tgyE5AziEzk1ABcjyiTKwGkgW+FBXNLxg+EqIgGCIq4w4swikzUurFJ i0atcqFvHSlzI9rKZ3H+gZ8uOwpMlCFQSsdBToowlA06yG4TA/ududE23iqzcK/h5hqY fd9w== X-Received: by 10.68.171.229 with SMTP id ax5mr6160307pbc.125.1402337108660; Mon, 09 Jun 2014 11:05:08 -0700 (PDT) Received: from fainelli-desktop.broadcom.com (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPSA id ao4sm65149842pbc.51.2014.06.09.11.05.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Jun 2014 11:05:08 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Subject: [PATCH] irqchip: brcmstb-l2: Level-2 interrupts are edge sensitive Date: Mon, 9 Jun 2014 11:05:02 -0700 Message-Id: <1402337102-19428-1-git-send-email-f.fainelli@gmail.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140609_110530_517654_5B832D78 X-CRM114-Status: GOOD ( 10.83 ) X-Spam-Score: -0.8 (/) Cc: tglx@linutronix.de, Florian Fainelli , jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver was configuring the interrupt handler for the Level-2 interrupts to be "level" triggered while they are in fact "edge" triggered. Fix this by using the correct handler. Reported-by: Brian Norris Signed-off-by: Florian Fainelli --- drivers/irqchip/irq-brcmstb-l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c index 8ee2a36d5840..c15c840987d2 100644 --- a/drivers/irqchip/irq-brcmstb-l2.c +++ b/drivers/irqchip/irq-brcmstb-l2.c @@ -150,7 +150,7 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np, /* Allocate a single Generic IRQ chip for this node */ ret = irq_alloc_domain_generic_chips(data->domain, 32, 1, - np->full_name, handle_level_irq, clr, 0, 0); + np->full_name, handle_edge_irq, clr, 0, 0); if (ret) { pr_err("failed to allocate generic irq chip\n"); goto out_free_domain;