| Message ID | 1402424839-25514-1-git-send-email-sboyd@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Jun 10, 2014, at 1:27 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: > The sdhci core was refactored recently and some of those > refactorings required changes in every sdhci platform driver. > Those updates happened around the same time as when the msm > driver was merged so the refactorings missed the msm driver. > Hook in the basic library functions so that we can boot apq8074 > dragonboards again instead of crashing when we try to jump to > NULL function pointers. > > Reported-by: Kevin Hilman <khilman@linaro.org> > Cc: Georgi Djakov <gdjakov@mm-sol.com> > Cc: Russell King <rmk+kernel@arm.linux.org.uk> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- > > Patch based on next-20140610 > > drivers/mmc/host/sdhci-msm.c | 4 ++++ > 1 file changed, 4 insertions(+) Acked-by: Kumar Gala <galak@codeaurora.org> Feel free to pick up this version of the patch and ignore mine. - k
On 10.06.14, 21:27, Stephen Boyd wrote: > The sdhci core was refactored recently and some of those > refactorings required changes in every sdhci platform driver. > Those updates happened around the same time as when the msm > driver was merged so the refactorings missed the msm driver. > Hook in the basic library functions so that we can boot apq8074 > dragonboards again instead of crashing when we try to jump to > NULL function pointers. > > Reported-by: Kevin Hilman <khilman@linaro.org> > Cc: Georgi Djakov <gdjakov@mm-sol.com> > Cc: Russell King <rmk+kernel@arm.linux.org.uk> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Reviewed-by: Georgi Djakov <gdjakov@mm-sol.com>
Stephen Boyd <sboyd@codeaurora.org> writes: > The sdhci core was refactored recently and some of those > refactorings required changes in every sdhci platform driver. > Those updates happened around the same time as when the msm > driver was merged so the refactorings missed the msm driver. > Hook in the basic library functions so that we can boot apq8074 > dragonboards again instead of crashing when we try to jump to > NULL function pointers. > > Reported-by: Kevin Hilman <khilman@linaro.org> > Cc: Georgi Djakov <gdjakov@mm-sol.com> > Cc: Russell King <rmk+kernel@arm.linux.org.uk> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Tested-by: Kevin Hilman <khilman@linaro.org> I verifed that this patch on top of next-20140610 gets the qcom dragonboard booting again. Kevin
On 10 June 2014 20:27, Stephen Boyd <sboyd@codeaurora.org> wrote: > The sdhci core was refactored recently and some of those > refactorings required changes in every sdhci platform driver. > Those updates happened around the same time as when the msm > driver was merged so the refactorings missed the msm driver. > Hook in the basic library functions so that we can boot apq8074 > dragonboards again instead of crashing when we try to jump to > NULL function pointers. > > Reported-by: Kevin Hilman <khilman@linaro.org> > Cc: Georgi Djakov <gdjakov@mm-sol.com> > Cc: Russell King <rmk+kernel@arm.linux.org.uk> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Thanks! Applied for fixes. Kind regards Uffe > --- > > Patch based on next-20140610 > > drivers/mmc/host/sdhci-msm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index acb0e9eb55f1..40573a58486a 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -468,6 +468,10 @@ MODULE_DEVICE_TABLE(of, sdhci_msm_dt_match); > > static struct sdhci_ops sdhci_msm_ops = { > .platform_execute_tuning = sdhci_msm_execute_tuning, > + .reset = sdhci_reset, > + .set_clock = sdhci_set_clock, > + .set_bus_width = sdhci_set_bus_width, > + .set_uhs_signaling = sdhci_set_uhs_signaling, > }; > > static int sdhci_msm_probe(struct platform_device *pdev) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation >
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index acb0e9eb55f1..40573a58486a 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -468,6 +468,10 @@ MODULE_DEVICE_TABLE(of, sdhci_msm_dt_match); static struct sdhci_ops sdhci_msm_ops = { .platform_execute_tuning = sdhci_msm_execute_tuning, + .reset = sdhci_reset, + .set_clock = sdhci_set_clock, + .set_bus_width = sdhci_set_bus_width, + .set_uhs_signaling = sdhci_set_uhs_signaling, }; static int sdhci_msm_probe(struct platform_device *pdev)
The sdhci core was refactored recently and some of those refactorings required changes in every sdhci platform driver. Those updates happened around the same time as when the msm driver was merged so the refactorings missed the msm driver. Hook in the basic library functions so that we can boot apq8074 dragonboards again instead of crashing when we try to jump to NULL function pointers. Reported-by: Kevin Hilman <khilman@linaro.org> Cc: Georgi Djakov <gdjakov@mm-sol.com> Cc: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- Patch based on next-20140610 drivers/mmc/host/sdhci-msm.c | 4 ++++ 1 file changed, 4 insertions(+)