From patchwork Sat Jun 14 01:47:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick X-Patchwork-Id: 4352101 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DBE81BEEAA for ; Sat, 14 Jun 2014 01:52:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1C8072026D for ; Sat, 14 Jun 2014 01:52:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3484020320 for ; Sat, 14 Jun 2014 01:52:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wvd5D-0000Hw-FZ; Sat, 14 Jun 2014 01:48:39 +0000 Received: from mail-ie0-x22a.google.com ([2607:f8b0:4001:c03::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wvd59-0000GZ-HC for linux-arm-kernel@lists.infradead.org; Sat, 14 Jun 2014 01:48:36 +0000 Received: by mail-ie0-f170.google.com with SMTP id tr6so3181743ieb.15 for ; Fri, 13 Jun 2014 18:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:signed-off-by; bh=h3lVZ6WfQHYL/qgIbxL6CtoB/0qPcFKG/Lz2IS56Irg=; b=LQIdQ2lUQMwVmVrxfMhyPzcNR5+aPO8NvmnLqb4AERiQCbQO5auZiLgHsmHd4Srldl uu51Fy676H5XQR8t+jNtD4fVtAqB4CXkfB95FN3UxJbeHLkpnuhrGWQnOAqOWVhLKHus 846+t++9Eis/jD0BEVPOZda6tWg6d6BVGybyBrnz+3xE4mNX4vuVOG5SUT2CA0daAktn luXknb6Y4yksi2z7W0MDXTcYv0qgZiglEV1JxHvljQeG+Ebbq+IW1T0PAxTEYDUtXXxe /sUQZzSUnBmdglbtz1YY/UY+bD7eH0oNMT7glY9yFrtjZx8cfiyaImUR50vry77FPOaM DVNA== X-Received: by 10.50.118.102 with SMTP id kl6mr9200634igb.7.1402710493343; Fri, 13 Jun 2014 18:48:13 -0700 (PDT) Received: from nick-System-Product-Name.phub.net.cable.rogers.com (CPE0026f3330aca-CM0026f3330ac6.cpe.net.cable.rogers.com. [99.232.64.167]) by mx.google.com with ESMTPSA id 2sm232195igs.17.2014.06.13.18.48.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Jun 2014 18:48:12 -0700 (PDT) From: Nick X-Google-Original-From: Nick To: emilio@elopez.com.ar Subject: [PATCH] Fixes two memory leaks in drivers/clk/sunxi/clk-sunxi.c Date: Fri, 13 Jun 2014 21:47:53 -0400 Message-Id: <1402710473-3295-1-git-send-email-nickkrause@sympatico.ca> X-Mailer: git-send-email 1.9.1 Signed-off-by: Nicholas Krause X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140613_184835_628048_708D1FA2 X-CRM114-Status: UNSURE ( 8.36 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.1 (/) Cc: maxime.ripard@free-electrons.com, mturquette@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 4264834..07b45d1 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -41,9 +41,11 @@ static void __init sun4i_osc_clk_setup(struct device_node *node) const char *clk_name = node->name; u32 rate; - if (of_property_read_u32(node, "clock-frequency", &rate)) + if (of_property_read_u32(node, "clock-frequency", &rate)) { + kfree(fixed); + kfree(gate); return; - + } /* allocate fixed-rate and gate clock structs */ fixed = kzalloc(sizeof(struct clk_fixed_rate), GFP_KERNEL); if (!fixed)