| Message ID | 1402875585-29025-1-git-send-email-anssi.hannula@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jun 16, 2014 at 02:39:44AM +0300, Anssi Hannula wrote: > The rxtx2 clock of i.MX6 S/PDIF is currently set to "asrc" clock. > However, according to SoC documentation, rxtx2 is connected to > ASRC_EXT_CLK, a different external clock. > > Testing on Cubox-i system seems to confirm that: when fsl_spdif is > forced to select rxtx2 as input clock, audio playback fails with an I/O > error. > > Set rxtx2 to the dummy clock by default to prevent fsl_spdif from > selecting it. > > Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi> > Cc: Nicolin Chen <Guangyu.Chen@freescale.com> > Cc: Mark Brown <broonie@kernel.org> Acked, thank you! P.S. We might also revive rxtx5 (SYSCLK) since the driver now has the capability to derive clock from it. > --- > > This one seems clear enough. > > arch/arm/boot/dts/imx6qdl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index ce0599134a69..3aef9a2f5fda 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -181,7 +181,7 @@ > <&sdma 15 18 0>; > dma-names = "rx", "tx"; > clocks = <&clks 197>, <&clks 3>, > - <&clks 197>, <&clks 107>, > + <&clks 197>, <&clks 0>, > <&clks 0>, <&clks 118>, > <&clks 0>, <&clks 139>, > <&clks 0>; > -- > 1.8.4.5 >
On Mon, Jun 16, 2014 at 02:39:44AM +0300, Anssi Hannula wrote: > The rxtx2 clock of i.MX6 S/PDIF is currently set to "asrc" clock. > However, according to SoC documentation, rxtx2 is connected to > ASRC_EXT_CLK, a different external clock. > > Testing on Cubox-i system seems to confirm that: when fsl_spdif is > forced to select rxtx2 as input clock, audio playback fails with an I/O > error. > > Set rxtx2 to the dummy clock by default to prevent fsl_spdif from > selecting it. > > Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi> > Cc: Nicolin Chen <Guangyu.Chen@freescale.com> > Cc: Mark Brown <broonie@kernel.org> Applied both, thanks.
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index ce0599134a69..3aef9a2f5fda 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -181,7 +181,7 @@ <&sdma 15 18 0>; dma-names = "rx", "tx"; clocks = <&clks 197>, <&clks 3>, - <&clks 197>, <&clks 107>, + <&clks 197>, <&clks 0>, <&clks 0>, <&clks 118>, <&clks 0>, <&clks 139>, <&clks 0>;
The rxtx2 clock of i.MX6 S/PDIF is currently set to "asrc" clock. However, according to SoC documentation, rxtx2 is connected to ASRC_EXT_CLK, a different external clock. Testing on Cubox-i system seems to confirm that: when fsl_spdif is forced to select rxtx2 as input clock, audio playback fails with an I/O error. Set rxtx2 to the dummy clock by default to prevent fsl_spdif from selecting it. Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi> Cc: Nicolin Chen <Guangyu.Chen@freescale.com> Cc: Mark Brown <broonie@kernel.org> --- This one seems clear enough. arch/arm/boot/dts/imx6qdl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)