| Message ID | 1403705032-14835-4-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Pankaj, On 25.06.2014 16:03, Pankaj Dubey wrote: > As we have removed static mappings from "regs-pmu.h" it does not > need map.h anymore. But "platsmp.c" needed this and till now it > got included indirectly. So lets move header inclusion of > "mach/map.h" from "regs-pmu.h" to "platsmp.c". > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > Reviewed-by: Tomasz Figa <t.figa@samsung.com> > --- > arch/arm/mach-exynos/platsmp.c | 2 ++ > arch/arm/mach-exynos/regs-pmu.h | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > IMHO this could be squashed with previous patch. Best regards, Tomasz
Hi Tomasz, On Monday, June 30, 2014 Tomasz Figa wrote: > Hi Pankaj, > > On 25.06.2014 16:03, Pankaj Dubey wrote: > > As we have removed static mappings from "regs-pmu.h" it does not need > > map.h anymore. But "platsmp.c" needed this and till now it got > > included indirectly. So lets move header inclusion of "mach/map.h" > > from "regs-pmu.h" to "platsmp.c". > > > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> > > --- > > arch/arm/mach-exynos/platsmp.c | 2 ++ > > arch/arm/mach-exynos/regs-pmu.h | 2 -- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > IMHO this could be squashed with previous patch. > OK, will squash this. > Best regards, > Tomasz Thanks, Pankaj Dubey
diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 4b934e3..71add5b 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -26,6 +26,8 @@ #include <asm/smp_scu.h> #include <asm/firmware.h> +#include <mach/map.h> + #include "common.h" #include "regs-pmu.h" diff --git a/arch/arm/mach-exynos/regs-pmu.h b/arch/arm/mach-exynos/regs-pmu.h index 77afda4..efad6cb 100644 --- a/arch/arm/mach-exynos/regs-pmu.h +++ b/arch/arm/mach-exynos/regs-pmu.h @@ -12,8 +12,6 @@ #ifndef __ASM_ARCH_REGS_PMU_H #define __ASM_ARCH_REGS_PMU_H __FILE__ -#include <mach/map.h> - #define S5P_CENTRAL_SEQ_CONFIGURATION 0x0200 #define S5P_CENTRAL_LOWPWR_CFG (1 << 16)