From patchwork Mon Jun 30 02:52:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick X-Patchwork-Id: 4445381 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EAC86BEEAA for ; Mon, 30 Jun 2014 02:57:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3A54A202E9 for ; Mon, 30 Jun 2014 02:57:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 545882024F for ; Mon, 30 Jun 2014 02:57:24 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X1RiP-0005xQ-Gn; Mon, 30 Jun 2014 02:53:09 +0000 Received: from mail-ig0-x22b.google.com ([2607:f8b0:4001:c05::22b]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X1RiM-0005v3-Pf for linux-arm-kernel@lists.infradead.org; Mon, 30 Jun 2014 02:53:07 +0000 Received: by mail-ig0-f171.google.com with SMTP id h18so3854293igc.16 for ; Sun, 29 Jun 2014 19:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=/J6KKteZ8iAgR17r/14DqWvqq4szhV8/ZPgOFbpppng=; b=nP/c3IIcunnYlEDo36sC/qFt1FKD9gsONBQbHBHx2hWIuTRtl/BXHJJ4fzV1tTI6SL LlkEjcH2wNd8USOVS9Z04Vygo3wNF9yjECxmlSQjBLZ2ppVkL4PCDlOG+iCAf78M+pt3 bLUdTjNSr1q2yCnu1tfeoDBGf74lK5+VMRdCbweLM/dEt/B1vqegaP1RwP7f3Wwyw9FK CwoDzcF3Z6axzg3p95LjYCnCEvNYqk6mIgrqzogVYGiq763AWM9RujpnD1LHbH3Xw0MD KlBwlZxXl3KCIjZdQyYru41vsc+J3YaEN5wuFHcLZr0w3LlcatrXKuxFGJFYsyj3Mw5x hM9Q== X-Received: by 10.50.138.99 with SMTP id qp3mr29097110igb.12.1404096765039; Sun, 29 Jun 2014 19:52:45 -0700 (PDT) Received: from nick-System-Product-Name.phub.net.cable.rogers.com (CPE0026f3330aca-CM0026f3330ac6.cpe.net.cable.rogers.com. [99.232.64.167]) by mx.google.com with ESMTPSA id j10sm9840585igv.17.2014.06.29.19.52.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 29 Jun 2014 19:52:44 -0700 (PDT) From: Nicholas Krause To: ulli.kroll@googlemail.com Subject: [PATCH] Fixes gemmi_idle in file idle.c Date: Sun, 29 Jun 2014 22:52:40 -0400 Message-Id: <1404096760-5239-1-git-send-email-xerofoify@gmail.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140629_195306_888748_5D7EE576 X-CRM114-Status: GOOD ( 10.07 ) X-Spam-Score: -0.1 (/) Cc: linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP disables the IRQ line in gemmi_idle before calling cpu_do_idle. In addition, according to the Fixme message in this file fixes races that may occur due to not disabling the IRQ before calling cpu_do_idle. Signed-off-by: Nicholas Krause --- arch/arm/mach-gemini/idle.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-gemini/idle.c b/arch/arm/mach-gemini/idle.c index ddf8ec9..2880f5a 100644 --- a/arch/arm/mach-gemini/idle.c +++ b/arch/arm/mach-gemini/idle.c @@ -17,8 +17,7 @@ static void gemini_idle(void) * disabled. */ - /* FIXME: Enabling interrupts here is racy! */ - local_irq_enable(); + local_irq_disable(); cpu_do_idle(); }