diff mbox

[1/3] ARM: exynos: remove unused <mach/memory.h>

Message ID 1404295043-6661-1-git-send-email-u.kleine-koenig@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Uwe Kleine-König July 2, 2014, 9:57 a.m. UTC
ARCH_EXYNOS doesn't select NEED_MACH_MEMORY_H, so <asm/memory.h> doesn't
include <mach/memory.h> and so this file is not used and can go away.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org
---
 arch/arm/mach-exynos/include/mach/memory.h | 27 ---------------------------
 1 file changed, 27 deletions(-)
 delete mode 100644 arch/arm/mach-exynos/include/mach/memory.h

Comments

Tomasz Figa July 8, 2014, 11:47 a.m. UTC | #1
Hi Uwe,

On 02.07.2014 11:57, Uwe Kleine-König wrote:
> ARCH_EXYNOS doesn't select NEED_MACH_MEMORY_H, so <asm/memory.h> doesn't
> include <mach/memory.h> and so this file is not used and can go away.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: linux-samsung-soc@vger.kernel.org
> ---
>  arch/arm/mach-exynos/include/mach/memory.h | 27 ---------------------------
>  1 file changed, 27 deletions(-)
>  delete mode 100644 arch/arm/mach-exynos/include/mach/memory.h

Thanks for the patch.

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

[boot tested on Exynos4412-based Trats2 board]
Tested-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz
Sachin Kamat July 8, 2014, 3:20 p.m. UTC | #2
On Wed, Jul 2, 2014 at 3:27 PM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> ARCH_EXYNOS doesn't select NEED_MACH_MEMORY_H, so <asm/memory.h> doesn't
> include <mach/memory.h> and so this file is not used and can go away.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---

Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>

Tested on Arndale octa board (Exynos 5420).

 Tested-by: Sachin Kamat <sachin.kamat@samsung.com>
Uwe Kleine-König July 22, 2014, 7:51 a.m. UTC | #3
Hello,

who takes care of this series?

In fact they are all orthogonal to each other.

The first patch

	ARM: exynos: remove unused <mach/memory.h>

has been reviewed and tested by Tomasz Figa and Sachin Kamat. Can the
Samsung people pick it up? Or armsoc?

Patch 2 (v2!)

	ARM: remove remaining definitions of PLAT_PHYS_OFFSET from <mach/memory.h>

touches several arch/arm/mach-*/include/mach/memory.h and
arch/arm/Kconfig. armsoc? Russell?

Patch 3 fixes a warning regarding nommu and touches the Kconfig entry
for Integrator and Renesas (non-multiplatform). armsoc?

Best regards
Uwe
Olof Johansson July 22, 2014, 4:14 p.m. UTC | #4
On Tue, Jul 22, 2014 at 12:51 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hello,
>
> who takes care of this series?
>
> In fact they are all orthogonal to each other.
>
> The first patch
>
>         ARM: exynos: remove unused <mach/memory.h>
>
> has been reviewed and tested by Tomasz Figa and Sachin Kamat. Can the
> Samsung people pick it up? Or armsoc?

Kukjin should apply this one.

> Patch 2 (v2!)
>
>         ARM: remove remaining definitions of PLAT_PHYS_OFFSET from <mach/memory.h>
>
> touches several arch/arm/mach-*/include/mach/memory.h and
> arch/arm/Kconfig. armsoc? Russell?

This can go through either, but Russell has already reviewed it once
so send it to his patch tracker.

> Patch 3 fixes a warning regarding nommu and touches the Kconfig entry
> for Integrator and Renesas (non-multiplatform). armsoc?

Don't know without seeing the patch. What's the patch subject so I can find it?


-Olof
Kim Kukjin July 22, 2014, 11:37 p.m. UTC | #5
On 07/23/14 01:14, Olof Johansson wrote:
> On Tue, Jul 22, 2014 at 12:51 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de>  wrote:
>> Hello,
>>
>> who takes care of this series?
>>
>> In fact they are all orthogonal to each other.
>>
>> The first patch
>>
>>          ARM: exynos: remove unused<mach/memory.h>
>>
>> has been reviewed and tested by Tomasz Figa and Sachin Kamat. Can the
>> Samsung people pick it up? Or armsoc?
>
> Kukjin should apply this one.
>
Oh, thanks for gentle reminder and I've applied into 2nd cleanup.

Thanks,
Kukjin


>> Patch 2 (v2!)
>>
>>          ARM: remove remaining definitions of PLAT_PHYS_OFFSET from<mach/memory.h>
>>
>> touches several arch/arm/mach-*/include/mach/memory.h and
>> arch/arm/Kconfig. armsoc? Russell?
>
> This can go through either, but Russell has already reviewed it once
> so send it to his patch tracker.
>
>> Patch 3 fixes a warning regarding nommu and touches the Kconfig entry
>> for Integrator and Renesas (non-multiplatform). armsoc?
>
> Don't know without seeing the patch. What's the patch subject so I can find it?
Uwe Kleine-König July 23, 2014, 7:58 p.m. UTC | #6
Hello,

On Tue, Jul 22, 2014 at 09:14:33AM -0700, Olof Johansson wrote:
> > Patch 2 (v2!)
> >
> >         ARM: remove remaining definitions of PLAT_PHYS_OFFSET from <mach/memory.h>
> >
> > touches several arch/arm/mach-*/include/mach/memory.h and
> > arch/arm/Kconfig. armsoc? Russell?
> 
> This can go through either, but Russell has already reviewed it once
> so send it to his patch tracker.
> 
> > Patch 3 fixes a warning regarding nommu and touches the Kconfig entry
> > for Integrator and Renesas (non-multiplatform). armsoc?
> 
> Don't know without seeing the patch. What's the patch subject so I can find it?
I talked to Olof on irc. I sent patches 2 and 3 to the patch tracker as

	http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8112/1

and

	http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8113/1

Best regards
Uwe
diff mbox

Patch

diff --git a/arch/arm/mach-exynos/include/mach/memory.h b/arch/arm/mach-exynos/include/mach/memory.h
deleted file mode 100644
index 2a4cdb7cb326..000000000000
--- a/arch/arm/mach-exynos/include/mach/memory.h
+++ /dev/null
@@ -1,27 +0,0 @@ 
-/* linux/arch/arm/mach-exynos4/include/mach/memory.h
- *
- * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd.
- *		http://www.samsung.com
- *
- * EXYNOS4 - Memory definitions
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
-*/
-
-#ifndef __ASM_ARCH_MEMORY_H
-#define __ASM_ARCH_MEMORY_H __FILE__
-
-#define PLAT_PHYS_OFFSET		UL(0x40000000)
-
-#ifndef CONFIG_ARM_LPAE
-/* Maximum of 256MiB in one bank */
-#define MAX_PHYSMEM_BITS	32
-#define SECTION_SIZE_BITS	28
-#else
-#define MAX_PHYSMEM_BITS	36
-#define SECTION_SIZE_BITS	31
-#endif
-
-#endif /* __ASM_ARCH_MEMORY_H */