| Message ID | 1404315664-3174-3-git-send-email-t.figa@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Tomasz, On Wed, Jul 2, 2014 at 9:11 PM, Tomasz Figa <t.figa@samsung.com> wrote: > This patch adds .request() and .free() operations to gpio_chip of > pinctrl-samsung driver, which call pinctrl request and free helpers to > request and free pinctrl pin along with GPIO pin. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > --- > drivers/pinctrl/pinctrl-samsung.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c > index 779c8bc..6e099d6 100644 > --- a/drivers/pinctrl/pinctrl-samsung.c > +++ b/drivers/pinctrl/pinctrl-samsung.c > @@ -779,7 +779,8 @@ static int samsung_pinctrl_register(struct platform_device *pdev, > pin_bank = &drvdata->ctrl->pin_banks[bank]; > pin_bank->grange.name = pin_bank->name; > pin_bank->grange.id = bank; > - pin_bank->grange.pin_base = pin_bank->pin_base; > + pin_bank->grange.pin_base = drvdata->ctrl->base > + + pin_bank->pin_base; Is this a fix?
On 04.07.2014 11:41, Sachin Kamat wrote: > Hi Tomasz, > > On Wed, Jul 2, 2014 at 9:11 PM, Tomasz Figa <t.figa@samsung.com> wrote: >> This patch adds .request() and .free() operations to gpio_chip of >> pinctrl-samsung driver, which call pinctrl request and free helpers to >> request and free pinctrl pin along with GPIO pin. >> >> Signed-off-by: Tomasz Figa <t.figa@samsung.com> >> --- >> drivers/pinctrl/pinctrl-samsung.c | 15 ++++++++++++++- >> 1 file changed, 14 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c >> index 779c8bc..6e099d6 100644 >> --- a/drivers/pinctrl/pinctrl-samsung.c >> +++ b/drivers/pinctrl/pinctrl-samsung.c >> @@ -779,7 +779,8 @@ static int samsung_pinctrl_register(struct platform_device *pdev, >> pin_bank = &drvdata->ctrl->pin_banks[bank]; >> pin_bank->grange.name = pin_bank->name; >> pin_bank->grange.id = bank; >> - pin_bank->grange.pin_base = pin_bank->pin_base; >> + pin_bank->grange.pin_base = drvdata->ctrl->base >> + + pin_bank->pin_base; > > Is this a fix? > Hmm, could be. I haven't observed any issues due to this without further patches from this series, so I'm not sure if this needs to be sent as a separate fix, but I might split this patch into two if necessary. Best regards, Tomasz
On Wed, Jul 2, 2014 at 5:41 PM, Tomasz Figa <t.figa@samsung.com> wrote: > This patch adds .request() and .free() operations to gpio_chip of > pinctrl-samsung driver, which call pinctrl request and free helpers to > request and free pinctrl pin along with GPIO pin. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c index 779c8bc..6e099d6 100644 --- a/drivers/pinctrl/pinctrl-samsung.c +++ b/drivers/pinctrl/pinctrl-samsung.c @@ -779,7 +779,8 @@ static int samsung_pinctrl_register(struct platform_device *pdev, pin_bank = &drvdata->ctrl->pin_banks[bank]; pin_bank->grange.name = pin_bank->name; pin_bank->grange.id = bank; - pin_bank->grange.pin_base = pin_bank->pin_base; + pin_bank->grange.pin_base = drvdata->ctrl->base + + pin_bank->pin_base; pin_bank->grange.base = pin_bank->gpio_chip.base; pin_bank->grange.npins = pin_bank->gpio_chip.ngpio; pin_bank->grange.gc = &pin_bank->gpio_chip; @@ -789,7 +790,19 @@ static int samsung_pinctrl_register(struct platform_device *pdev, return 0; } +static int samsung_gpio_request(struct gpio_chip *chip, unsigned offset) +{ + return pinctrl_request_gpio(chip->base + offset); +} + +static void samsung_gpio_free(struct gpio_chip *chip, unsigned offset) +{ + pinctrl_free_gpio(chip->base + offset); +} + static const struct gpio_chip samsung_gpiolib_chip = { + .request = samsung_gpio_request, + .free = samsung_gpio_free, .set = samsung_gpio_set, .get = samsung_gpio_get, .direction_input = samsung_gpio_direction_input,
This patch adds .request() and .free() operations to gpio_chip of pinctrl-samsung driver, which call pinctrl request and free helpers to request and free pinctrl pin along with GPIO pin. Signed-off-by: Tomasz Figa <t.figa@samsung.com> --- drivers/pinctrl/pinctrl-samsung.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)