diff mbox

[2/2] ia64: Remove Linux/x86 domain support

Message ID 1405263538-27589-3-git-send-email-richard@nod.at (mailing list archive)
State New, archived
Headers show

Commit Message

Richard Weinberger July 13, 2014, 2:58 p.m. UTC
ia64 exec domain support seems to be incomplete and unused.
It has no custom handler nor a custom signal map.
All it does is showing up in /proc/execdomains.
Let's rip it out.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/ia64/mm/init.c | 25 -------------------------
 1 file changed, 25 deletions(-)

Comments

Tony Luck July 16, 2014, 11:20 p.m. UTC | #1
On Sun, Jul 13, 2014 at 7:58 AM, Richard Weinberger <richard@nod.at> wrote:

Did you read the comment?

> -/*
> - * Even when CONFIG_IA32_SUPPORT is not enabled it is
> - * useful to have the Linux/x86 domain registered to
> - * avoid an attempted module load when emulators call
> - * personality(PER_LINUX32). This saves several milliseconds
> - * on each such call.
> - */

I don't know if there are still people using ia32el to run x86 binaries
on ia64 ... but if there are, they may be sad at the extra delays.

-Tony
Richard Weinberger July 17, 2014, 7:47 a.m. UTC | #2
Am 17.07.2014 01:20, schrieb Tony Luck:
> On Sun, Jul 13, 2014 at 7:58 AM, Richard Weinberger <richard@nod.at> wrote:
> 
> Did you read the comment?

Sure, please see my comment below.

>> -/*
>> - * Even when CONFIG_IA32_SUPPORT is not enabled it is
>> - * useful to have the Linux/x86 domain registered to
>> - * avoid an attempted module load when emulators call
>> - * personality(PER_LINUX32). This saves several milliseconds
>> - * on each such call.
>> - */
> 
> I don't know if there are still people using ia32el to run x86 binaries
> on ia64 ... but if there are, they may be sad at the extra delays.

As written in 0/, the plan is to get rid of exec domains at all.
Therefore personality(PER_LINUX32) would no longer try to request a module.

Thanks,
//richard
diff mbox

Patch

diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c
index 25c3502..d4a6b79 100644
--- a/arch/ia64/mm/init.c
+++ b/arch/ia64/mm/init.c
@@ -660,31 +660,6 @@  int arch_remove_memory(u64 start, u64 size)
 #endif
 #endif
 
-/*
- * Even when CONFIG_IA32_SUPPORT is not enabled it is
- * useful to have the Linux/x86 domain registered to
- * avoid an attempted module load when emulators call
- * personality(PER_LINUX32). This saves several milliseconds
- * on each such call.
- */
-static struct exec_domain ia32_exec_domain;
-
-static int __init
-per_linux32_init(void)
-{
-	ia32_exec_domain.name = "Linux/x86";
-	ia32_exec_domain.handler = NULL;
-	ia32_exec_domain.pers_low = PER_LINUX32;
-	ia32_exec_domain.pers_high = PER_LINUX32;
-	ia32_exec_domain.signal_map = default_exec_domain.signal_map;
-	ia32_exec_domain.signal_invmap = default_exec_domain.signal_invmap;
-	register_exec_domain(&ia32_exec_domain);
-
-	return 0;
-}
-
-__initcall(per_linux32_init);
-
 /**
  * show_mem - give short summary of memory stats
  *