| Message ID | 1405500863-19696-2-git-send-email-mperttunen@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/16/2014 02:24 PM, Mikko Perttunen wrote: > This patch adds device tree binding documentation for the SATA > controller found on NVIDIA Tegra SoCs. > > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> > --- > .../devicetree/bindings/ata/tegra-sata.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ata/tegra-sata.txt > > diff --git a/Documentation/devicetree/bindings/ata/tegra-sata.txt b/Documentation/devicetree/bindings/ata/tegra-sata.txt > new file mode 100644 > index 0000000..946f207 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/tegra-sata.txt > @@ -0,0 +1,30 @@ > +Tegra124 SoC SATA AHCI controller > + > +Required properties : > +- compatible : "nvidia,tegra124-ahci". > +- reg : Should contain 2 entries: > + - AHCI register set (SATA BAR5) > + - SATA register set > +- interrupts : Defines the interrupt used by SATA > +- clocks : Must contain an entry for each entry in clock-names. > + See ../clocks/clock-bindings.txt for details. > +- clock-names : Must include the following entries: > + - sata > + - sata-oob > + - cml1 > + - pll_e It would be more readable if it like this... Required properties : - compatible : "nvidia,tegra124-ahci". - reg : Should contain 2 entries: - AHCI register set (SATA BAR5) - SATA register set - interrupts : Defines the interrupt used by SATA - clocks : Must contain an entry for each entry in clock-names. See ../clocks/clock-bindings.txt for details. .... > +- resets : Must contain an entry for each entry in reset-names. > + See ../reset/reset.txt for details. > +- reset-names : Must include the following entries: > + - sata > + - sata-oob > + - sata-cold > +- phys : Must contain an entry for each entry in phy-names. > + See ../phy/phy-bindings.txt for details. > +- phy-names : Must include the following entries: > + - sata-phy : XUSB PADCTL SATA PHY > +- hvdd-supply : Defines the SATA HVDD regulator > +- vddio-supply : Defines the SATA VDDIO regulator > +- avdd-supply : Defines the SATA AVDD regulator > +- target-5v-supply : Defines the SATA 5V power regulator > +- target-12v-supply : Defines the SATA 12V power regulator Same....
Thanks for you comment. I decided to keep the format as is for now, however, to keep a consistent style between all binding files describing Tegra hardware. Mikko On 16/07/14 12:26, Varka Bhadram wrote: > On 07/16/2014 02:24 PM, Mikko Perttunen wrote: >> This patch adds device tree binding documentation for the SATA >> controller found on NVIDIA Tegra SoCs. >> >> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> >> --- >> .../devicetree/bindings/ata/tegra-sata.txt | 30 ++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/ata/tegra-sata.txt >> >> diff --git a/Documentation/devicetree/bindings/ata/tegra-sata.txt b/Documentation/devicetree/bindings/ata/tegra-sata.txt >> new file mode 100644 >> index 0000000..946f207 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/ata/tegra-sata.txt >> @@ -0,0 +1,30 @@ >> +Tegra124 SoC SATA AHCI controller >> + >> +Required properties : >> +- compatible : "nvidia,tegra124-ahci". >> +- reg : Should contain 2 entries: >> + - AHCI register set (SATA BAR5) >> + - SATA register set >> +- interrupts : Defines the interrupt used by SATA >> +- clocks : Must contain an entry for each entry in clock-names. >> + See ../clocks/clock-bindings.txt for details. >> +- clock-names : Must include the following entries: >> + - sata >> + - sata-oob >> + - cml1 >> + - pll_e > > It would be more readable if it like this... > > Required properties : > - compatible : "nvidia,tegra124-ahci". > - reg : Should contain 2 entries: > - AHCI register set (SATA BAR5) > - SATA register set > - interrupts : Defines the interrupt used by SATA > - clocks : Must contain an entry for each entry in clock-names. > See ../clocks/clock-bindings.txt for details. > .... > >> +- resets : Must contain an entry for each entry in reset-names. >> + See ../reset/reset.txt for details. >> +- reset-names : Must include the following entries: >> + - sata >> + - sata-oob >> + - sata-cold >> +- phys : Must contain an entry for each entry in phy-names. >> + See ../phy/phy-bindings.txt for details. >> +- phy-names : Must include the following entries: >> + - sata-phy : XUSB PADCTL SATA PHY >> +- hvdd-supply : Defines the SATA HVDD regulator >> +- vddio-supply : Defines the SATA VDDIO regulator >> +- avdd-supply : Defines the SATA AVDD regulator >> +- target-5v-supply : Defines the SATA 5V power regulator >> +- target-12v-supply : Defines the SATA 12V power regulator > > Same.... > >
diff --git a/Documentation/devicetree/bindings/ata/tegra-sata.txt b/Documentation/devicetree/bindings/ata/tegra-sata.txt new file mode 100644 index 0000000..946f207 --- /dev/null +++ b/Documentation/devicetree/bindings/ata/tegra-sata.txt @@ -0,0 +1,30 @@ +Tegra124 SoC SATA AHCI controller + +Required properties : +- compatible : "nvidia,tegra124-ahci". +- reg : Should contain 2 entries: + - AHCI register set (SATA BAR5) + - SATA register set +- interrupts : Defines the interrupt used by SATA +- clocks : Must contain an entry for each entry in clock-names. + See ../clocks/clock-bindings.txt for details. +- clock-names : Must include the following entries: + - sata + - sata-oob + - cml1 + - pll_e +- resets : Must contain an entry for each entry in reset-names. + See ../reset/reset.txt for details. +- reset-names : Must include the following entries: + - sata + - sata-oob + - sata-cold +- phys : Must contain an entry for each entry in phy-names. + See ../phy/phy-bindings.txt for details. +- phy-names : Must include the following entries: + - sata-phy : XUSB PADCTL SATA PHY +- hvdd-supply : Defines the SATA HVDD regulator +- vddio-supply : Defines the SATA VDDIO regulator +- avdd-supply : Defines the SATA AVDD regulator +- target-5v-supply : Defines the SATA 5V power regulator +- target-12v-supply : Defines the SATA 12V power regulator
This patch adds device tree binding documentation for the SATA controller found on NVIDIA Tegra SoCs. Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> --- .../devicetree/bindings/ata/tegra-sata.txt | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/ata/tegra-sata.txt