From patchwork Thu Jul 17 14:48:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastian Hecht X-Patchwork-Id: 4576121 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5BE43C0514 for ; Thu, 17 Jul 2014 14:51:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9198C20160 for ; Thu, 17 Jul 2014 14:51:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 840FA2017D for ; Thu, 17 Jul 2014 14:51:40 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X7n0N-0000kd-GD; Thu, 17 Jul 2014 14:49:55 +0000 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X7n04-0000S4-UP for linux-arm-kernel@lists.infradead.org; Thu, 17 Jul 2014 14:49:37 +0000 Received: by mail-wg0-f50.google.com with SMTP id n12so2125285wgh.21 for ; Thu, 17 Jul 2014 07:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hLoWhAb2YLqJ3JhqT9fyLVz6kYJtlqizMFbzoWSkmc8=; b=ZvT4itoyOY+CZf/S1tq9wZ5XyRJdcSMY1L4W+CFCiYutHT67Gzgcqh+0cW03sFjqSF AuWN1jvzggy24vFCB/wBXiBymG400ct6HvithEEXjF6/XC6GCEXtdSg70MBuCd60KRvZ mDgUzCzUspwnam2s5JDtLaH9FuqTRD4lIQhSK+fFTo1ZLWLDzJyYxT4v1xQGdVlYQJyv VI4PO/Gk53qeSiPGTnwCbvPZzIixJVaMlknEBqwk97BfIFDP7TP1yJ4jlr0+VibqAloQ YBFKCnu3sWkpMmQheIgOptgSs6/E1/lAWM12rHOWdBsouYy7t6Tn2+GHY0pJor3ODNBI 0sxg== X-Received: by 10.180.74.42 with SMTP id q10mr22825955wiv.39.1405608554805; Thu, 17 Jul 2014 07:49:14 -0700 (PDT) Received: from ipanema.Speedport_W723_V_Typ_A_1_01_001 (p5B3C7F4A.dip0.t-ipconnect.de. [91.60.127.74]) by mx.google.com with ESMTPSA id di7sm6646044wjb.34.2014.07.17.07.49.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Jul 2014 07:49:14 -0700 (PDT) From: Bastian Hecht To: linux-i2c@vger.kernel.org Subject: [PATCH v2 4/5] i2c: sc3c2410: Remove suspension check Date: Thu, 17 Jul 2014 16:48:39 +0200 Message-Id: <1405608520-5644-4-git-send-email-hechtb@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1405608520-5644-1-git-send-email-hechtb@gmail.com> References: <1405608520-5644-1-git-send-email-hechtb@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140717_074937_145915_B6213619 X-CRM114-Status: GOOD ( 12.15 ) X-Spam-Score: -0.8 (/) Cc: Kukjin Kim , Wolfram Sang , Linux-SH , Tomoya MORINAGA , open list , Bastian Hecht , "moderated list:ARM/SAMSUNG ARM A..." , Ben Dooks , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We now take care of suspension in the i2c core code. So we can remove this check here. Signed-off-by: Bastian Hecht --- same as v1 drivers/i2c/busses/i2c-s3c2410.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index e828a1d..568b993 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -103,7 +103,6 @@ enum s3c24xx_i2c_state { struct s3c24xx_i2c { wait_queue_head_t wait; kernel_ulong_t quirks; - unsigned int suspended:1; struct i2c_msg *msg; unsigned int msg_num; @@ -714,9 +713,6 @@ static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c, unsigned long timeout; int ret; - if (i2c->suspended) - return -EIO; - ret = s3c24xx_i2c_set_master(i2c); if (ret != 0) { dev_err(i2c->dev, "cannot get bus (error %d)\n", ret); @@ -1257,16 +1253,6 @@ static int s3c24xx_i2c_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP -static int s3c24xx_i2c_suspend_noirq(struct device *dev) -{ - struct platform_device *pdev = to_platform_device(dev); - struct s3c24xx_i2c *i2c = platform_get_drvdata(pdev); - - i2c->suspended = 1; - - return 0; -} - static int s3c24xx_i2c_resume(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); @@ -1275,7 +1261,6 @@ static int s3c24xx_i2c_resume(struct device *dev) clk_prepare_enable(i2c->clk); s3c24xx_i2c_init(i2c); clk_disable_unprepare(i2c->clk); - i2c->suspended = 0; return 0; } @@ -1284,7 +1269,6 @@ static int s3c24xx_i2c_resume(struct device *dev) #ifdef CONFIG_PM static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = { #ifdef CONFIG_PM_SLEEP - .suspend_noirq = s3c24xx_i2c_suspend_noirq, .resume = s3c24xx_i2c_resume, #endif };