| Message ID | 1405686607-8126-3-git-send-email-antoine.tenart@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 07/18/2014 04:30 PM, Antoine Ténart wrote: > The Berlin SATA PHY drives the PHY related to the SATA interface. Add > the corresponding documentation. > Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com> > --- > .../devicetree/bindings/phy/berlin-sata-phy.txt | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/berlin-sata-phy.txt > diff --git a/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt > new file mode 100644 > index 000000000000..88f8c23384c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt > @@ -0,0 +1,34 @@ > +Berlin SATA PHY > +--------------- > + > +Required properties: > +- compatible: should be "marvell,berlin2q-sata-phy" > +- address-cells: should be 1 > +- size-cells: should be 0 > +- phy-cells: from the generic PHY bindings, must be 1 It's "#address-cells", "#size-cells", and "#phy-cells". > +- reg: address and length of the register > +- clocks: reference to the clock entry > + > +Sub-nodes: > +Each PHY should be represented as a sub-node. Then "#phy-cells" should also belong to the sub-nodes. > + > +Sub-nodes required properties: > +- reg: the PHY number WBR, Sergei
Hi, On Fri, Jul 18, 2014 at 09:27:28PM +0400, Sergei Shtylyov wrote: > On 07/18/2014 04:30 PM, Antoine Ténart wrote: > > >diff --git a/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt > >new file mode 100644 > >index 000000000000..88f8c23384c0 > >--- /dev/null > >+++ b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt > >@@ -0,0 +1,34 @@ > >+Berlin SATA PHY > >+--------------- > >+ > >+Required properties: > >+- compatible: should be "marvell,berlin2q-sata-phy" > >+- address-cells: should be 1 > >+- size-cells: should be 0 > >+- phy-cells: from the generic PHY bindings, must be 1 > > It's "#address-cells", "#size-cells", and "#phy-cells". Sure. > > >+- reg: address and length of the register > >+- clocks: reference to the clock entry > >+ > >+Sub-nodes: > >+Each PHY should be represented as a sub-node. > > Then "#phy-cells" should also belong to the sub-nodes. No, because the PHY provider is still the parent. Antoine
diff --git a/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt new file mode 100644 index 000000000000..88f8c23384c0 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt @@ -0,0 +1,34 @@ +Berlin SATA PHY +--------------- + +Required properties: +- compatible: should be "marvell,berlin2q-sata-phy" +- address-cells: should be 1 +- size-cells: should be 0 +- phy-cells: from the generic PHY bindings, must be 1 +- reg: address and length of the register +- clocks: reference to the clock entry + +Sub-nodes: +Each PHY should be represented as a sub-node. + +Sub-nodes required properties: +- reg: the PHY number + +Example: + sata_phy: phy@f7e900a0 { + compatible = "marvell,berlin2q-sata-phy"; + reg = <0xf7e900a0 0x200>; + clocks = <&chip CLKID_SATA>; + #address-cells = <1>; + #size-cells = <0>; + #phy-cells = <1>; + + sata-phy@0 { + reg = <0>; + }; + + sata-phy@1 { + reg = <1>; + }; + };
The Berlin SATA PHY drives the PHY related to the SATA interface. Add the corresponding documentation. Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com> --- .../devicetree/bindings/phy/berlin-sata-phy.txt | 34 ++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/berlin-sata-phy.txt