From patchwork Sun Jul 20 04:06:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick X-Patchwork-Id: 4590381 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DDF75C0514 for ; Sun, 20 Jul 2014 04:09:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1D52C2010F for ; Sun, 20 Jul 2014 04:09:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 596312010E for ; Sun, 20 Jul 2014 04:09:32 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X8iOc-0000HM-Pq; Sun, 20 Jul 2014 04:06:46 +0000 Received: from mail-ie0-x231.google.com ([2607:f8b0:4001:c03::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X8iOb-0000Fj-4p for linux-arm-kernel@lists.infradead.org; Sun, 20 Jul 2014 04:06:45 +0000 Received: by mail-ie0-f177.google.com with SMTP id at20so5567444iec.8 for ; Sat, 19 Jul 2014 21:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=MzGxtsd5sPqSx3rDO7w2ERfAiH9N1KaFnBdffFoYLQA=; b=d98/hSMKs43TwDV89Osbv2lTcWE1Mkf5b415awrtzNMvEJq9840jcup2G5gV0Llwhw etUJhbGTFamOhgK8SsfcX826lbT7szR4UpEJLGp6t77BXE2qpvQIWopQBG3TejEDqx5a 3JVo6ElT3HGFda1IkEyORz6dR1c1cpE4SFYkNgs7wiR/19qqmSfAScfcjmKzgzczU8dA yWf0oLeAmdYhE5WOKVHBBhlIREHGsIQEkFm0IFSXuY+vPMB57v2Rqco0WF46m1OLIrB0 cTs9xKPwoIBgbEY3gCKdpUcnRUGbLBqV1kTbhiQWN1/KDRplE4OoNyPbSeHULijDNdOl Pfog== X-Received: by 10.50.83.4 with SMTP id m4mr27810270igy.25.1405829183113; Sat, 19 Jul 2014 21:06:23 -0700 (PDT) Received: from nick-System-Product-Name.phub.net.cable.rogers.com (CPE0026f3330aca-CM0026f3330ac6.cpe.net.cable.rogers.com. [99.232.64.167]) by mx.google.com with ESMTPSA id p17sm24099244igi.15.2014.07.19.21.06.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 19 Jul 2014 21:06:22 -0700 (PDT) From: Nicholas Krause To: linux@arm.linux.org.uk Subject: [PATCH] arm: Fix me in bios32.c Date: Sun, 20 Jul 2014 00:06:19 -0400 Message-Id: <1405829179-19476-1-git-send-email-xerofoify@gmail.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140719_210645_231862_EF87B1E5 X-CRM114-Status: GOOD ( 12.20 ) X-Spam-Score: -0.1 (/) Cc: thomas.petazzoni@free-electrons.com, jason@lakedaemon.net, will.deacon@arm.com, linux-kernel@vger.kernel.org, wangyijing@huawei.com, thierry.reding@gmail.com, m-karicheri2@ti.com, bhelgaas@google.com, yinghai@kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This fixs a fix me in bios32.c for pci_fixup_it8152 as this if statement is incorrect needs to be checked against the class bits not the whole address for the two or conditions and since they don't have define statements outside of their numeratical value. Signed-off-by: Nicholas Krause --- arch/arm/kernel/bios32.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c index 17a26c1..b2217af 100644 --- a/arch/arm/kernel/bios32.c +++ b/arch/arm/kernel/bios32.c @@ -254,11 +254,9 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CONTAQ, PCI_DEVICE_ID_CONTAQ_82C693, pci_ static void pci_fixup_it8152(struct pci_dev *dev) { int i; - /* fixup for ITE 8152 devices */ - /* FIXME: add defines for class 0x68000 and 0x80103 */ if ((dev->class >> 8) == PCI_CLASS_BRIDGE_HOST || - dev->class == 0x68000 || - dev->class == 0x80103) { + (dev->class >> 8) == 0x680 || + (dev->class >> 8) == 0x801) { for (i = 0; i < PCI_NUM_RESOURCES; i++) { dev->resource[i].start = 0; dev->resource[i].end = 0;