From patchwork Fri Aug 8 16:33:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Scheiblauer X-Patchwork-Id: 4697181 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1FD55C0338 for ; Fri, 8 Aug 2014 16:35:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 432EC2017A for ; Fri, 8 Aug 2014 16:35:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0A5520179 for ; Fri, 8 Aug 2014 16:35:21 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XFn6i-0005LI-Gy; Fri, 08 Aug 2014 16:33:32 +0000 Received: from longnose.sharkbay.at ([78.46.205.195] helo=smtp.sharkbay.at) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XFn6f-0005GN-30 for linux-arm-kernel@lists.infradead.org; Fri, 08 Aug 2014 16:33:30 +0000 Received: by smtp.sharkbay.at (Postfix, from userid 112) id A7E7BA5B9E; Fri, 8 Aug 2014 18:33:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Message-ID: <1407515584.19455.9.camel@sharkbay.at> Subject: [PATCH 1/1] undo workaround for i.mx6 silicon errata ERR006687 which resulted in an unstable ethernet connection (lost interrupts?) From: Thomas Scheiblauer To: Fabio Estevam Date: Fri, 08 Aug 2014 18:33:04 +0200 In-Reply-To: References: <1407503758.19455.1.camel@sharkbay.at> <20140808132754.GC30282@n2100.arm.linux.org.uk> <1407507023.19455.3.camel@sharkbay.at> <20140808143008.GD30282@n2100.arm.linux.org.uk> <1407509932.19455.7.camel@sharkbay.at> Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140808_093329_515483_E600D4EC X-CRM114-Status: GOOD ( 20.31 ) X-Spam-Score: -0.7 (/) Cc: Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP > > > > On Fre, 2014-08-08 at 12:46 -0300, Fabio Estevam wrote: > > Hi Thomas, > > > > On Fri, Aug 8, 2014 at 11:58 AM, Thomas Scheiblauer wrote: > > > > >> So, what I'm asking is to try without this workaround in case there is > > >> some interaction there, thus testing the same interrupt configuration > > >> that I've had here for the last 10 months without the kind of issues > > >> you're reporting. Sometimes, workarounds for one problem end up causing > > >> other problem elsewhere. > > >> > > > > > > Indeed, commenting out these 2 lines in > > > arch/arm/boot/dts/imx6qdl-wandboard.dtsi fixes my problem without having > > > to increase TX_RING_SIZE. > > > Thank you very much! > > > > Could you please send a patch for imx6qdl-wandboard.dtsi? Please > > provide the details of the problem in the commit log. > > > > Thanks Ok, here is my attempt on the patch. I've also removed the respective lines from all the other imx6qdl-*.dtsi files. Signed-off-by: Thomas Scheiblauer --- arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 2 -- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 2 -- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 2 -- arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 -- 4 files changed, 8 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi index 42ff525..cf4e6db 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi @@ -169,8 +169,6 @@ txd1-skew-ps = <0>; txd2-skew-ps = <0>; txd3-skew-ps = <0>; - interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, - <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi index 009abd6..f47e82f 100644 --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi @@ -65,8 +65,6 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii"; - interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, - <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi index 0a36129..ebfcab4 100644 --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi @@ -168,8 +168,6 @@ txd1-skew-ps = <0>; txd2-skew-ps = <0>; txd3-skew-ps = <0>; - interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, - <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi index 6461f66..3b61c9a 100644 --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi @@ -257,8 +257,6 @@ pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii"; phy-reset-gpios = <&gpio3 29 0>; - interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, - <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; status = "okay"; };