| Message ID | 1407933685-12404-3-git-send-email-mperttunen@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/13/2014 06:41 AM, Mikko Perttunen wrote: > Sometimes, hardware blocks want to issue requests to devices > connected to I2C buses by itself. In such case, the bus the > target device resides on must be configured into a register. > For this purpose, each I2C controller has a defined ID known > by the hardware. Add a property for these IDs to the device tree > bindings, so that drivers can know what ID to write to a hardware > register when configuring a block that sends I2C messages autonomously. > diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt > +Optional properties: > +- nvidia,controller-id: ID of controller when referred to in > + hardware registers. I'd prefer to put this information into the thermal trip node, since this represents what ID the PMC uses to communicate with the I2C controller, and there's no absolute guarantee that multiple clients that communicate directly with an I2C controller would use the same numbering scheme. If that doesn't work, can be at least name this nvidia,pmc-controller-id or nvidia,id-in-pmc so that if there are different numbering schemes, there's a clear path to represent this in different properties without conflicting names?
On Wed, Aug 20, 2014 at 02:19:35PM -0600, Stephen Warren wrote: > On 08/13/2014 06:41 AM, Mikko Perttunen wrote: > >Sometimes, hardware blocks want to issue requests to devices > >connected to I2C buses by itself. In such case, the bus the > >target device resides on must be configured into a register. > >For this purpose, each I2C controller has a defined ID known > >by the hardware. Add a property for these IDs to the device tree > >bindings, so that drivers can know what ID to write to a hardware > >register when configuring a block that sends I2C messages autonomously. > > >diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt > > >+Optional properties: > >+- nvidia,controller-id: ID of controller when referred to in > >+ hardware registers. > > I'd prefer to put this information into the thermal trip node, since this > represents what ID the PMC uses to communicate with the I2C controller, and > there's no absolute guarantee that multiple clients that communicate > directly with an I2C controller would use the same numbering scheme. > > If that doesn't work, can be at least name this nvidia,pmc-controller-id or > nvidia,id-in-pmc so that if there are different numbering schemes, there's a > clear path to represent this in different properties without conflicting > names? This is the ID of the controller used internally by the documentation. And as far as I can tell every aspect of the documentation refers to the controllers by the same ID (clocks, interrupts, ...). The PMC uses this same numbering scheme. That makes the ID about as canonical as it gets, so the extra prefix isn't warranted in my opinion. I'd argue that if ever there was a case where something was referring to the controller using a different ID then that should be considered the oddball and get special treatment. Thierry
On 08/21/2014 01:05 AM, Thierry Reding wrote: > On Wed, Aug 20, 2014 at 02:19:35PM -0600, Stephen Warren wrote: >> On 08/13/2014 06:41 AM, Mikko Perttunen wrote: >>> Sometimes, hardware blocks want to issue requests to devices >>> connected to I2C buses by itself. In such case, the bus the >>> target device resides on must be configured into a register. >>> For this purpose, each I2C controller has a defined ID known >>> by the hardware. Add a property for these IDs to the device tree >>> bindings, so that drivers can know what ID to write to a hardware >>> register when configuring a block that sends I2C messages autonomously. >> >>> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt >> >>> +Optional properties: >>> +- nvidia,controller-id: ID of controller when referred to in >>> + hardware registers. >> >> I'd prefer to put this information into the thermal trip node, since this >> represents what ID the PMC uses to communicate with the I2C controller, and >> there's no absolute guarantee that multiple clients that communicate >> directly with an I2C controller would use the same numbering scheme. >> >> If that doesn't work, can be at least name this nvidia,pmc-controller-id or >> nvidia,id-in-pmc so that if there are different numbering schemes, there's a >> clear path to represent this in different properties without conflicting >> names? > > This is the ID of the controller used internally by the documentation. > And as far as I can tell every aspect of the documentation refers to the > controllers by the same ID (clocks, interrupts, ...). The PMC uses this > same numbering scheme. That makes the ID about as canonical as it gets, > so the extra prefix isn't warranted in my opinion. > > I'd argue that if ever there was a case where something was referring to > the controller using a different ID then that should be considered the > oddball and get special treatment. This is certainly true in practice in current SoCs, but in general, there's no reason why every HW module that talks to I2C HW modules needs to be hooked up to all of them in the same order, especially if SoCs start getting put together by mixing/matching components from all kinds of vendors etc. Still, since they are today, I suppose that binding is fine; we can always modify the binding for any new SoC (and associated compatible value) in the future if the current rule ever gets broken. The code will be a little annoying though.
diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt index 87507e9..e9e5994 100644 --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt @@ -57,6 +57,10 @@ Required properties: - rx - tx +Optional properties: +- nvidia,controller-id: ID of controller when referred to in + hardware registers. + Example: i2c@7000c000 { @@ -71,5 +75,6 @@ Example: reset-names = "i2c"; dmas = <&apbdma 16>, <&apbdma 16>; dma-names = "rx", "tx"; + nvidia,controller-id = <0>; status = "disabled"; };
Sometimes, hardware blocks want to issue requests to devices connected to I2C buses by itself. In such case, the bus the target device resides on must be configured into a register. For this purpose, each I2C controller has a defined ID known by the hardware. Add a property for these IDs to the device tree bindings, so that drivers can know what ID to write to a hardware register when configuring a block that sends I2C messages autonomously. Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> --- Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt | 5 +++++ 1 file changed, 5 insertions(+)