| Message ID | 1408645143-25690-2-git-send-email-dmurphy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 08/21/2014 10:19 PM, Dan Murphy wrote: > DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. > Adding dt binding for this part > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > .../devicetree/bindings/input/ti,drv2667.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt > diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt > new file mode 100644 > index 0000000..525216d > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt > @@ -0,0 +1,18 @@ > +Texas Instruments - drv2667 Haptics driver > + > +The drv2667 uses serial control bus communicates through I2C protocols I can't parse that. > + > +Required properties: > + - compatible - "ti,drv2667" - DRV2667 > + - reg - I2C slave address > + - vbat-supply - Required supply regulator > + > +Example: > + > +drv2667: drv2667@59 { > + compatible = "ti,drv2667"; > + reg = <0x59>; You say "vbat-supply" is mandatory, yet you don't have it in your example? WBR, Sergei
Sergei On 08/21/2014 01:29 PM, Sergei Shtylyov wrote: > Hello. > > On 08/21/2014 10:19 PM, Dan Murphy wrote: > >> DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. >> Adding dt binding for this part > >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> .../devicetree/bindings/input/ti,drv2667.txt | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt > >> diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt >> new file mode 100644 >> index 0000000..525216d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt >> @@ -0,0 +1,18 @@ >> +Texas Instruments - drv2667 Haptics driver >> + >> +The drv2667 uses serial control bus communicates through I2C protocols > > I can't parse that. > Hmmm.. It made sense when I typed it. Will fix >> + >> +Required properties: >> + - compatible - "ti,drv2667" - DRV2667 >> + - reg - I2C slave address >> + - vbat-supply - Required supply regulator >> + >> +Example: >> + >> +drv2667: drv2667@59 { >> + compatible = "ti,drv2667"; >> + reg = <0x59>; > > You say "vbat-supply" is mandatory, yet you don't have it in your example? I will add this as well. > > WBR, Sergei > >
Hello. On 08/21/2014 10:19 PM, Dan Murphy wrote: > DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. > Adding dt binding for this part > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > .../devicetree/bindings/input/ti,drv2667.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt > diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt > new file mode 100644 > index 0000000..525216d > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt > @@ -0,0 +1,18 @@ > +Texas Instruments - drv2667 Haptics driver > + > +The drv2667 uses serial control bus communicates through I2C protocols > + > +Required properties: > + - compatible - "ti,drv2667" - DRV2667 > + - reg - I2C slave address > + - vbat-supply - Required supply regulator > + > +Example: > + > +drv2667: drv2667@59 { The ePAPR standard [1] has something to say on this matter: "The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model." > + compatible = "ti,drv2667"; Indented too much to the right. > + reg = <0x59>; Still no "vbat-supply"... :-/ > +}; [...] WBR, Sergei
Sergei Thanks for the additional comments On 08/21/2014 02:04 PM, Sergei Shtylyov wrote: > Hello. > > On 08/21/2014 10:19 PM, Dan Murphy wrote: > >> DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. >> Adding dt binding for this part > >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> .../devicetree/bindings/input/ti,drv2667.txt | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt > >> diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt >> new file mode 100644 >> index 0000000..525216d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt >> @@ -0,0 +1,18 @@ >> +Texas Instruments - drv2667 Haptics driver >> + >> +The drv2667 uses serial control bus communicates through I2C protocols >> + >> +Required properties: >> + - compatible - "ti,drv2667" - DRV2667 >> + - reg - I2C slave address >> + - vbat-supply - Required supply regulator >> + >> +Example: >> + >> +drv2667: drv2667@59 { > > The ePAPR standard [1] has something to say on this matter: What is this reference? Did not know this existed so wanted to read up on it. I can change it to haptics or vibrator > > "The name of a node should be somewhat generic, reflecting the function of the > device and not its precise programming model." > >> + compatible = "ti,drv2667"; > > Indented too much to the right. One tab to many. Got it > >> + reg = <0x59>; > > Still no "vbat-supply"... :-/ > Still have not sent in v2 of the patch yet. Waiting on other comments. >> +}; > [...] > > WBR, Sergei > >
On 08/21/2014 11:14 PM, Murphy, Dan wrote: [...] >>> DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. >>> Adding dt binding for this part >>> Signed-off-by: Dan Murphy <dmurphy@ti.com> >>> --- >>> .../devicetree/bindings/input/ti,drv2667.txt | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt >>> diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt >>> new file mode 100644 >>> index 0000000..525216d >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt >>> @@ -0,0 +1,18 @@ >>> +Texas Instruments - drv2667 Haptics driver >>> + >>> +The drv2667 uses serial control bus communicates through I2C protocols >>> + >>> +Required properties: >>> + - compatible - "ti,drv2667" - DRV2667 >>> + - reg - I2C slave address >>> + - vbat-supply - Required supply regulator >>> + >>> +Example: >>> + >>> +drv2667: drv2667@59 { >> The ePAPR standard [1] has something to say on this matter: > What is this reference? Did not know this existed so wanted to read up on it. Sorry, forgot to paste the link. :-< [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf WBR, Sergei
diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt new file mode 100644 index 0000000..525216d --- /dev/null +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt @@ -0,0 +1,18 @@ +Texas Instruments - drv2667 Haptics driver + +The drv2667 uses serial control bus communicates through I2C protocols + +Required properties: + - compatible - "ti,drv2667" - DRV2667 + - reg - I2C slave address + - vbat-supply - Required supply regulator + +Example: + +drv2667: drv2667@59 { + compatible = "ti,drv2667"; + reg = <0x59>; +}; + +For more product information please see the link below: +http://www.ti.com/product/drv2667
DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. Adding dt binding for this part Signed-off-by: Dan Murphy <dmurphy@ti.com> --- .../devicetree/bindings/input/ti,drv2667.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt