From patchwork Tue Sep 2 21:19:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 4828411 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 841499F32F for ; Tue, 2 Sep 2014 21:23:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 81CBD201DD for ; Tue, 2 Sep 2014 21:23:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A89E7201CD for ; Tue, 2 Sep 2014 21:23:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XOvVO-0004qG-MG; Tue, 02 Sep 2014 21:20:46 +0000 Received: from mail-pd0-x22c.google.com ([2607:f8b0:400e:c02::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XOvUd-0003C3-G3 for linux-arm-kernel@lists.infradead.org; Tue, 02 Sep 2014 21:19:59 +0000 Received: by mail-pd0-f172.google.com with SMTP id z10so9524137pdj.31 for ; Tue, 02 Sep 2014 14:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=APklUd8UsxuHHjvylALS6mrxY2EGfZSt5bfuIED77Ag=; b=F9d1kt1RpjPf+iJ8a/CjIFeAiaO4EBvPB51xYZdlXq2NPQ9WiQxYiFNPrLPmJCRrrP 7c93Z5Ffa84DqzBp7ydZ4F7+6CnbR4lGJUU6FSZFpgG88qua1Qy2JOYKVAaad8b1zQ9L v6qCcBsXTD51VFV1FEZI08Y5WFrtX3y+mgC523e5XUwJP914zGMw2dvkh80rtsbyteLv HvKO1QNeQhq0Hfrn/Tcv0e1hogLJfm/B/WseMNqIK7nY+nD1fbT63mequPLPqHu7mUXq m+Ttpua1O23yyNmVfHBmf0nOpvyzuQhXIHKxKPvWFOSKyh7zCBYvFVB5fglYQEnby42L Avcg== X-Received: by 10.68.57.194 with SMTP id k2mr50446588pbq.67.1409692777346; Tue, 02 Sep 2014 14:19:37 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id oa8sm6832952pdb.20.2014.09.02.14.19.35 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 02 Sep 2014 14:19:36 -0700 (PDT) From: Soren Brinkmann To: Michal Simek , Daniel Lezcano Subject: [PATCH v2 6/9] ARM: zynq: cpuidle: Remove pointless code Date: Tue, 2 Sep 2014 14:19:11 -0700 Message-Id: <1409692754-13437-7-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.1.0.1.g27b9230 In-Reply-To: <1409692754-13437-1-git-send-email-soren.brinkmann@xilinx.com> References: <1409692754-13437-1-git-send-email-soren.brinkmann@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140902_141959_553107_4C8EF19A X-CRM114-Status: GOOD ( 12.87 ) X-Spam-Score: -0.7 (/) Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , linux-pm@vger.kernel.org, Ian Campbell , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Rob Herring , =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , Kumar Gala , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Lezcano The core is not powered down, it is pointless to call the cpu_pm notifiers and switch to the global timer. Signed-off-by: Daniel Lezcano Reviewed-and-tested-by: Soren Brinkmann --- drivers/cpuidle/cpuidle-zynq.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/cpuidle/cpuidle-zynq.c b/drivers/cpuidle/cpuidle-zynq.c index aded75928028..c61b8b2a7c77 100644 --- a/drivers/cpuidle/cpuidle-zynq.c +++ b/drivers/cpuidle/cpuidle-zynq.c @@ -26,7 +26,6 @@ */ #include -#include #include #include #include @@ -38,15 +37,9 @@ static int zynq_enter_idle(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { - /* Devices must be stopped here */ - cpu_pm_enter(); - /* Add code for DDR self refresh start */ cpu_do_idle(); - /* Add code for DDR self refresh stop */ - cpu_pm_exit(); - return index; } @@ -59,8 +52,7 @@ static struct cpuidle_driver zynq_idle_driver = { .enter = zynq_enter_idle, .exit_latency = 10, .target_residency = 10000, - .flags = CPUIDLE_FLAG_TIME_VALID | - CPUIDLE_FLAG_TIMER_STOP, + .flags = CPUIDLE_FLAG_TIME_VALID, .name = "RAM_SR", .desc = "WFI and RAM Self Refresh", },