diff mbox

ARM: zynq: Add ISL9305 regulator on Parallella board

Message ID 1410003616-32077-1-git-send-email-broonie@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Mark Brown Sept. 6, 2014, 11:40 a.m. UTC
There is an ISL9305 regulator on the Parallella board, add it to the DT
along with descriptions of all the supplies.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm/boot/dts/zynq-parallella.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

Comments

Michal Simek Sept. 15, 2014, 1:26 p.m. UTC | #1
On 09/06/2014 01:40 PM, Mark Brown wrote:
> There is an ISL9305 regulator on the Parallella board, add it to the DT
> along with descriptions of all the supplies.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  arch/arm/boot/dts/zynq-parallella.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
> index 41afd9da6876..43ca89fb92e4 100644
> --- a/arch/arm/boot/dts/zynq-parallella.dts
> +++ b/arch/arm/boot/dts/zynq-parallella.dts
> @@ -53,6 +53,29 @@
>  
>  &i2c0 {
>  	status = "okay";
> +
> +	isl9305: isl9305@68 {
> +		compatible = "isl,isl9305";
> +		reg = <0x68>;
> +
> +		regulators {
> +			dcd1 {
> +				regulator-name = "VDD_DSP";
> +				regulator-always-on;
> +			};
> +			dcd2 {
> +				regulator-name = "1P35V";
> +				regulator-always-on;
> +			};
> +			ldo1 {
> +				regulator-name = "VDD_ADJ";
> +			};
> +			ldo2 {
> +				regulator-name = "VDD_GPIO";
> +				regulator-always-on;
> +			};
> +		};
> +	};
>  };
>  
>  &sdhci1 {
> 

Applied.

Thanks,
Michal
Andreas Färber Sept. 15, 2014, 1:32 p.m. UTC | #2
Am 15.09.2014 um 15:26 schrieb Michal Simek:
> On 09/06/2014 01:40 PM, Mark Brown wrote:
>> There is an ISL9305 regulator on the Parallella board, add it to the DT
>> along with descriptions of all the supplies.
>>
>> Signed-off-by: Mark Brown <broonie@kernel.org>
>> ---
>>  arch/arm/boot/dts/zynq-parallella.dts | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
>> index 41afd9da6876..43ca89fb92e4 100644
>> --- a/arch/arm/boot/dts/zynq-parallella.dts
>> +++ b/arch/arm/boot/dts/zynq-parallella.dts
>> @@ -53,6 +53,29 @@
>>  
>>  &i2c0 {
>>  	status = "okay";
>> +
>> +	isl9305: isl9305@68 {
>> +		compatible = "isl,isl9305";
>> +		reg = <0x68>;
>> +
>> +		regulators {
>> +			dcd1 {
>> +				regulator-name = "VDD_DSP";
>> +				regulator-always-on;
>> +			};
>> +			dcd2 {
>> +				regulator-name = "1P35V";
>> +				regulator-always-on;
>> +			};
>> +			ldo1 {
>> +				regulator-name = "VDD_ADJ";
>> +			};
>> +			ldo2 {
>> +				regulator-name = "VDD_GPIO";
>> +				regulator-always-on;
>> +			};
>> +		};
>> +	};
>>  };
>>  
>>  &sdhci1 {
>>
> 
> Applied.

Where exactly on the board did you spot that regulator? I did not spot
it on my pre-ordered board and wonder whether it might be a difference
of the revised RS-distributed board with the large heat sink?

Thanks,
Andreas
Mark Brown Sept. 15, 2014, 4:16 p.m. UTC | #3
On Mon, Sep 15, 2014 at 03:32:52PM +0200, Andreas Färber wrote:
> Am 15.09.2014 um 15:26 schrieb Michal Simek:

> > Applied.

> Where exactly on the board did you spot that regulator? I did not spot
> it on my pre-ordered board and wonder whether it might be a difference
> of the revised RS-distributed board with the large heat sink?

I didn't actually identify the physical device on the board, it's on
sheet 16 of the schematic.  The device is responsive to I2C and I'm
reading back the settings I'm expecting from the hardware.
Michal Simek Sept. 16, 2014, 12:27 p.m. UTC | #4
On 09/15/2014 06:16 PM, Mark Brown wrote:
> On Mon, Sep 15, 2014 at 03:32:52PM +0200, Andreas Färber wrote:
>> Am 15.09.2014 um 15:26 schrieb Michal Simek:
> 
>>> Applied.
> 
>> Where exactly on the board did you spot that regulator? I did not spot
>> it on my pre-ordered board and wonder whether it might be a difference
>> of the revised RS-distributed board with the large heat sink?
> 
> I didn't actually identify the physical device on the board, it's on
> sheet 16 of the schematic.  The device is responsive to I2C and I'm
> reading back the settings I'm expecting from the hardware.
> 

good that you have parallella hardware.

Thanks,
Michal
diff mbox

Patch

diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
index 41afd9da6876..43ca89fb92e4 100644
--- a/arch/arm/boot/dts/zynq-parallella.dts
+++ b/arch/arm/boot/dts/zynq-parallella.dts
@@ -53,6 +53,29 @@ 
 
 &i2c0 {
 	status = "okay";
+
+	isl9305: isl9305@68 {
+		compatible = "isl,isl9305";
+		reg = <0x68>;
+
+		regulators {
+			dcd1 {
+				regulator-name = "VDD_DSP";
+				regulator-always-on;
+			};
+			dcd2 {
+				regulator-name = "1P35V";
+				regulator-always-on;
+			};
+			ldo1 {
+				regulator-name = "VDD_ADJ";
+			};
+			ldo2 {
+				regulator-name = "VDD_GPIO";
+				regulator-always-on;
+			};
+		};
+	};
 };
 
 &sdhci1 {