From patchwork Mon Sep 22 18:02:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 4949561 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8104B9F2BB for ; Mon, 22 Sep 2014 18:05:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 458DB20155 for ; Mon, 22 Sep 2014 18:05:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB20D20121 for ; Mon, 22 Sep 2014 18:05:34 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XW7xW-0002th-Ri; Mon, 22 Sep 2014 18:03:34 +0000 Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XW7xP-0002pH-6W for linux-arm-kernel@lists.infradead.org; Mon, 22 Sep 2014 18:03:27 +0000 Received: by mail-pa0-f45.google.com with SMTP id lj1so4476800pab.4 for ; Mon, 22 Sep 2014 11:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BnE7sG+PYadAaCVVQlosym4hyNa7wo7OYATBpSDePZY=; b=0uS0LgKMCPpBzbf2Wzf8+w9f28h8bSTLDjsJEnGIJL1vBrZ3JTmfBzrI601fllwIa1 S7SdgQJCyAP1OKMJ5JkkdssxnLkuuR7qZCuJ7c5Qa4/fdEF4Ub/1brVpcDQ755OKOLpK e/dXjNp0UUOgn+HwbXXvH5B3B9bSTiOo99O0Ke8EUmEtA1UW0m+poo7o+uiUdW3u5tgB uElfvK2K2gTDpP0Gnhcs6t2MMqLEFP/CLB5Ncxy8z8KEGoJXBGa9ff7T6GOKV4cfuHVE nPuauwObltNhfkGQZx2p0qrKO9+3CZ59/Fk/z/3nQoAPt+G1wgHfglq9v/F6CPHsiiBm xQzw== X-Received: by 10.67.4.1 with SMTP id ca1mr28637240pad.50.1411408986404; Mon, 22 Sep 2014 11:03:06 -0700 (PDT) Received: from fainelli-desktop.broadcom.com (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPSA id l4sm9924098pbq.49.2014.09.22.11.03.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 22 Sep 2014 11:03:05 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] bus: brcmstb_gisb: register the fault code hook Date: Mon, 22 Sep 2014 11:02:45 -0700 Message-Id: <1411408966-15390-2-git-send-email-f.fainelli@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1411408966-15390-1-git-send-email-f.fainelli@gmail.com> References: <1411408966-15390-1-git-send-email-f.fainelli@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140922_110327_281147_7F2BF9DF X-CRM114-Status: GOOD ( 12.28 ) X-Spam-Score: -0.1 (/) Cc: thomas.petazzoni@free-electrons.com, Florian Fainelli , computersforpeace@gmail.com, linux-arm-kernel@lists.infradead.org, arnd@arndb.de X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 44127b771d9c31 ("bus: add Broadcom GISB bus arbiter timeout/error handler") added everything that is required to register an ARM fault handler for imprecise external aborts, except that there is nothing calling this currently. We do not need to export that specific function and have to update arch/arm/mach-bcm/brcmstb.c to call it, simply, register the fault handler during the probe() function of the driver. Signed-off-by: Florian Fainelli --- Changes in v3: - moved hook_fault_code as part of the probe function Changes in v2: - removed the accidental hunk that added saved_timeout since it does not belong in this patch drivers/bus/brcmstb_gisb.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c index f2cd6a2d40b4..41b09418f515 100644 --- a/drivers/bus/brcmstb_gisb.c +++ b/drivers/bus/brcmstb_gisb.c @@ -160,12 +160,6 @@ static int brcmstb_bus_error_handler(unsigned long addr, unsigned int fsr, return ret; } -void __init brcmstb_hook_fault_code(void) -{ - hook_fault_code(22, brcmstb_bus_error_handler, SIGBUS, 0, - "imprecise external abort"); -} - static irqreturn_t brcmstb_gisb_timeout_handler(int irq, void *dev_id) { brcmstb_gisb_arb_decode_addr(dev_id, "timeout"); @@ -261,6 +255,9 @@ static int brcmstb_gisb_arb_probe(struct platform_device *pdev) list_add_tail(&gdev->next, &brcmstb_gisb_arb_device_list); + hook_fault_code(22, brcmstb_bus_error_handler, SIGBUS, 0, + "imprecise external abort"); + dev_info(&pdev->dev, "registered mem: %p, irqs: %d, %d\n", gdev->base, timeout_irq, tea_irq);