| Message ID | 1413933960-25839-1-git-send-email-zyw@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Chris, On Tue, Oct 21, 2014 at 4:26 PM, Chris Zhong <zyw@rock-chips.com> wrote: > The pmu-sram is used to store resume code, suspend/resume need get the > address of it. Therefore add a binding and documentation for it. > > Signed-off-by: Tony Xie <xxx@rock-chips.com> > Signed-off-by: Chris Zhong <zyw@rock-chips.com> > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > .../devicetree/bindings/arm/rockchip/pmu-sram.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt > > diff --git a/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt b/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt > new file mode 100644 > index 0000000..77284c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt > @@ -0,0 +1,15 @@ > +Rockchip SRAM for pmu: > +------------------------------ > + > +The sram of pmu is used to store the function of resume from maskrom(the 1st > +level loader). It's probably best in this document to say that this is a common use of the "pmu-sram" because it keeps power even in low power states in the system. ...this SRAM could be used for other things as well. > +Required node properties: > +- compatible : should be "rockchip,rk3288-pmu-sram" > +- reg : physical base address and the size of the registers window > + > +Example: > + pmu_intmem@ff720000 { > + compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; > + reg = <0xff720000 0x4000>; As with the other patch, should probably change the size in the example to 0x1000 (4K). Otherwise this looks good to me. -Doug
Chris, On Tue, Oct 21, 2014 at 4:26 PM, Chris Zhong <zyw@rock-chips.com> wrote: > The pmu-sram is used to store resume code, suspend/resume need get the > address of it. Therefore add a binding and documentation for it. > > Signed-off-by: Tony Xie <xxx@rock-chips.com> > Signed-off-by: Chris Zhong <zyw@rock-chips.com> > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > .../devicetree/bindings/arm/rockchip/pmu-sram.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) Reviewed-by: Doug Anderson <dianders@chromium.org>
diff --git a/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt b/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt new file mode 100644 index 0000000..77284c0 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt @@ -0,0 +1,15 @@ +Rockchip SRAM for pmu: +------------------------------ + +The sram of pmu is used to store the function of resume from maskrom(the 1st +level loader). + +Required node properties: +- compatible : should be "rockchip,rk3288-pmu-sram" +- reg : physical base address and the size of the registers window + +Example: + pmu_intmem@ff720000 { + compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; + reg = <0xff720000 0x4000>; + };