| Message ID | 1414427215-14380-7-git-send-email-romain.perier@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 27, 2014 at 04:26:52PM +0000, Romain Perier wrote: > Signed-off-by: Romain Perier <romain.perier@gmail.com> > --- > arch/arm/boot/dts/tegra30-apalis.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi > index a5446cb..ced4436 100644 > --- a/arch/arm/boot/dts/tegra30-apalis.dtsi > +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi > @@ -412,7 +412,7 @@ > #interrupt-cells = <2>; > interrupt-controller; > > - ti,system-power-controller; > + system-power-controller; this board is broken until this patch is applied.
On Tue, Oct 28, 2014 at 1:42 AM, Felipe Balbi <balbi@ti.com> wrote: > On Mon, Oct 27, 2014 at 04:26:52PM +0000, Romain Perier wrote: >> Signed-off-by: Romain Perier <romain.perier@gmail.com> >> --- >> arch/arm/boot/dts/tegra30-apalis.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi >> index a5446cb..ced4436 100644 >> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi >> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi >> @@ -412,7 +412,7 @@ >> #interrupt-cells = <2>; >> interrupt-controller; >> >> - ti,system-power-controller; >> + system-power-controller; > > this board is broken until this patch is applied. It should not. Supporting a new property in the tps65911 is fine, but the old property must keep being supported to preserve DT compatibility. If a change removing support for "ti,system-power-controller" has landed in -next, then it should be removed.
The old property is supported. See "[PATCH v1 1/10]" ^^ (of_is_system_power_controller supports both properties...) 2014-10-28 5:34 GMT+01:00 Alexandre Courbot <gnurou@gmail.com>: > On Tue, Oct 28, 2014 at 1:42 AM, Felipe Balbi <balbi@ti.com> wrote: >> On Mon, Oct 27, 2014 at 04:26:52PM +0000, Romain Perier wrote: >>> Signed-off-by: Romain Perier <romain.perier@gmail.com> >>> --- >>> arch/arm/boot/dts/tegra30-apalis.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi >>> index a5446cb..ced4436 100644 >>> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi >>> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi >>> @@ -412,7 +412,7 @@ >>> #interrupt-cells = <2>; >>> interrupt-controller; >>> >>> - ti,system-power-controller; >>> + system-power-controller; >> >> this board is broken until this patch is applied. > > It should not. Supporting a new property in the tps65911 is fine, but > the old property must keep being supported to preserve DT > compatibility. If a change removing support for > "ti,system-power-controller" has landed in -next, then it should be > removed.
diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi index a5446cb..ced4436 100644 --- a/arch/arm/boot/dts/tegra30-apalis.dtsi +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi @@ -412,7 +412,7 @@ #interrupt-cells = <2>; interrupt-controller; - ti,system-power-controller; + system-power-controller; #gpio-cells = <2>; gpio-controller;
Signed-off-by: Romain Perier <romain.perier@gmail.com> --- arch/arm/boot/dts/tegra30-apalis.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)