From patchwork Thu Oct 30 00:56:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iyappan Subramanian X-Patchwork-Id: 5192711 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9F4439F7E6 for ; Thu, 30 Oct 2014 00:58:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D0A482025A for ; Thu, 30 Oct 2014 00:58:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26BC620219 for ; Thu, 30 Oct 2014 00:58:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xje21-0007fd-JV; Thu, 30 Oct 2014 00:56:05 +0000 Received: from exprod5og124.obsmtp.com ([64.18.0.212]) by bombadil.infradead.org with smtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xje1r-0007U4-5f for linux-arm-kernel@lists.infradead.org; Thu, 30 Oct 2014 00:55:55 +0000 Received: from mail-pd0-f171.google.com ([209.85.192.171]) (using TLSv1) by exprod5ob124.postini.com ([64.18.4.12]) with SMTP ID DSNKVFGMhrWOpd89HAdv7HnoIgMaUP3iAduh@postini.com; Wed, 29 Oct 2014 17:55:55 PDT Received: by mail-pd0-f171.google.com with SMTP id r10so4032289pdi.16 for ; Wed, 29 Oct 2014 17:55:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+5OszfleJdr6nLbdIB2Ip0Qhs6lddieztn/dEiy0wso=; b=Ufl+yIRFylssGbOrGQU0KN2XvrdY6gZHwxbiLoIh/NpemQ2/UeBM+kmV3BkCgR75oH 24k5A1uKBvNkZGvyUmW7/g+O3iG/f4hl3dPdGEbex0jI2KBi5UQ6C53VnoKlor6jO72F IXTVshMnsohO9zH7yJe2DfLRUmUIHQrqEdPKH8O/4g09vUINv0wr5fAwiRR31Cj29i8Z Zwy3Zf5BoMG7asmKQ9XF/lMExSXlHKF+FAzoK2WLfj73gS8IgcwgVD+AflnlOa9pbFwA ap44SVe48TJlLly/FZJC8Yv0XmUypVAT/Mau1tg7Mwe8gOCj7eEh1s849//XiXQQsT4v BPOg== X-Gm-Message-State: ALoCoQki9qvFShHoql9LERgJRkketVAx2VKjqXLTHfsjU+Z6LZ6YPfwELZNTxJgbJnHpoqzT4SQFC+7b8kzhsZc/2JJHBOO82KoIOu1OPBYb4J3xPC+OaTFGPnjfa52ZRhzE5plC4WC7bTczU89b1Ado1+lG9F/4Fsdyhmw1PlX2g9QLhwx88Fc= X-Received: by 10.66.237.98 with SMTP id vb2mr46906pac.144.1414630533970; Wed, 29 Oct 2014 17:55:33 -0700 (PDT) X-Received: by 10.66.237.98 with SMTP id vb2mr46884pac.144.1414630533781; Wed, 29 Oct 2014 17:55:33 -0700 (PDT) Received: from svdclab-13-11.amcc.com (67-207-112-226.static.wiline.com. [67.207.112.226]) by mx.google.com with ESMTPSA id jq5sm5398462pbc.32.2014.10.29.17.55.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 29 Oct 2014 17:55:32 -0700 (PDT) From: Iyappan Subramanian To: davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v1 1/2] dtb: xgene: fix: Disable 10GbE and SGMII based 1GbE by default Date: Wed, 29 Oct 2014 17:56:19 -0700 Message-Id: <1414630580-24640-2-git-send-email-isubramanian@apm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1414630580-24640-1-git-send-email-isubramanian@apm.com> References: <1414630580-24640-1-git-send-email-isubramanian@apm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141029_175555_277461_BCBDDBC8 X-CRM114-Status: GOOD ( 13.02 ) X-Spam-Score: -2.3 (--) Cc: kchudgar@apm.com, patches@apm.com, linux-arm-kernel@lists.infradead.org, Iyappan Subramanian X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch disables 10GbE and SGMII based 1GbE interfaces by default for backward compatibility with older firmware, which don't support these interfaces. The following kernel crash was reported when using older firmware (<= 1.13.28). [ 0.980000] libphy: APM X-Gene MDIO bus: probed [ 1.130000] Unhandled fault: synchronous external abort (0x96000010) at 0xffffff800009a17c [ 1.140000] Internal error: : 96000010 [#1] SMP [ 1.140000] Modules linked in: [ 1.140000] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.17.0+ #21 [ 1.140000] task: ffffffc3f0110000 ti: ffffffc3f0064000 task.ti: ffffffc3f0064000 [ 1.140000] PC is at ioread32+0x58/0x68 [ 1.140000] LR is at xgene_enet_setup_ring+0x18c/0x1cc [ 1.140000] pc : [] lr : [] pstate: a0000045 [ 1.140000] sp : ffffffc3f0067b20 [ 1.140000] x29: ffffffc3f0067b20 x28: ffffffc000aa8ea0 [ 1.140000] x27: ffffffc000bb2000 x26: ffffffc000a64270 [ 1.140000] x25: ffffffc000b05ad8 x24: ffffffc0ff99ba58 [ 1.140000] x23: 0000000000004000 x22: 0000000000004000 [ 1.140000] x21: 0000000000000200 x20: 0000000000200000 [ 1.140000] x19: ffffffc0ff99ba18 x18: ffffffc0007a6000 [ 1.140000] x17: 0000000000000007 x16: 000000000000000e [ 1.140000] x15: 0000000000000001 x14: 0000000000000000 [ 1.140000] x13: ffffffbeedb71320 x12: 00000000ffffff80 [ 1.140000] x11: 0000000000000002 x10: 0000000000000000 [ 1.140000] x9 : 0000000000000000 x8 : ffffffc3eb2a4000 [ 1.140000] x7 : 0000000000000000 x6 : 0000000000000000 [ 1.140000] x5 : 0000000001080000 x4 : 000000007d654010 [ 1.140000] x3 : ffffffffffffffff x2 : 000000000003ffff [ 1.140000] x1 : ffffff800009a17c x0 : ffffff800009a17c The issue was that the older firmware does not support 10GbE and SGMII based 1GBE interfaces. The newer firmware (version 1.13.29) will support 10GbE and SGMII based 1GbE and it will patch the dtb to enable these nodes on the fly. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar Reported-by: Dann Frazier --- arch/arm64/boot/dts/apm-mustang.dts | 8 -------- arch/arm64/boot/dts/apm-storm.dtsi | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/arch/arm64/boot/dts/apm-mustang.dts b/arch/arm64/boot/dts/apm-mustang.dts index 2e25de0..f649000 100644 --- a/arch/arm64/boot/dts/apm-mustang.dts +++ b/arch/arm64/boot/dts/apm-mustang.dts @@ -40,11 +40,3 @@ &menet { status = "ok"; }; - -&sgenet0 { - status = "ok"; -}; - -&xgenet { - status = "ok"; -}; diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi index 295c72d..52488c8 100644 --- a/arch/arm64/boot/dts/apm-storm.dtsi +++ b/arch/arm64/boot/dts/apm-storm.dtsi @@ -621,7 +621,7 @@ }; }; - sgenet0: ethernet@1f210000 { + sgenet0: sgenet@1f210000 { compatible = "apm,xgene-enet"; status = "disabled"; reg = <0x0 0x1f210000 0x0 0x10000>, @@ -635,7 +635,7 @@ phy-connection-type = "sgmii"; }; - xgenet: ethernet@1f610000 { + xgenet: xgenet@1f610000 { compatible = "apm,xgene-enet"; status = "disabled"; reg = <0x0 0x1f610000 0x0 0xd100>,