From patchwork Thu Oct 30 11:20:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 5196151 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A7D84C11AC for ; Thu, 30 Oct 2014 11:25:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E644620219 for ; Thu, 30 Oct 2014 11:25:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC08220260 for ; Thu, 30 Oct 2014 11:25:39 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xjnoo-0007Qa-ED; Thu, 30 Oct 2014 11:23:06 +0000 Received: from mailout3.w1.samsung.com ([210.118.77.13]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XjnnV-0006o9-U8 for linux-arm-kernel@lists.infradead.org; Thu, 30 Oct 2014 11:21:47 +0000 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NE9008GH90HJW70@mailout3.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 30 Oct 2014 11:24:17 +0000 (GMT) X-AuditID: cbfec7f4-b7f6c6d00000120b-47-54521f356cea Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 04.BF.04619.53F12545; Thu, 30 Oct 2014 11:21:25 +0000 (GMT) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NE9009H68VFGU90@eusync3.samsung.com>; Thu, 30 Oct 2014 11:21:25 +0000 (GMT) From: Krzysztof Kozlowski To: Samuel Ortiz , Lee Jones , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, Ben Dooks , Kukjin Kim , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 09/14] regulator: max77686: Initialize opmode explicitly to normal mode Date: Thu, 30 Oct 2014 12:20:48 +0100 Message-id: <1414668053-31370-10-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1414668053-31370-1-git-send-email-k.kozlowski@samsung.com> References: <1414668053-31370-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNLMWRmVeSWpSXmKPExsVy+t/xq7qm8kEhBvOusFtsnLGe1WLSugNM FlMfPmGzuP7lOavF/CPnWC2O/i6weP3C0KJ3wVU2i7NNb9gt7n89ymjx7UoHk8Wmx9dYLS7v msNmMeP8PiaL25d5LdYeuctucbqb1UHQo6W5h83j7/PrLB5/V71g9tg56y67x6ZVnWwed67t YfOYdzLQY/OSeo++LasYPT5vkgvgiuKySUnNySxLLdK3S+DKeHiMpeAle8X029vZGhgvsHUx cnJICJhInN+4ghHCFpO4cG89UJyLQ0hgKaPEpjPTGSGcPiaJpvazYFVsAsYSm5cvAasSEehk lug52MsM4jALrGaS+HnlFDNIlbBAjMTSrlssIDaLgKrE58ObwLp5BTwktk39CLVbTuLkscms IDYnUHzNx3YgmwNonbvEvW/aExh5FzAyrGIUTS1NLihOSs811CtOzC0uzUvXS87P3cQICfAv OxgXH7M6xCjAwajEw+uwMSBEiDWxrLgy9xCjBAezkgjvarGgECHelMTKqtSi/Pii0pzU4kOM TBycUg2MG1z9SzL2Sq0Nv37ImvM68/HpFgZvZ1tmsE6dvvzIDNMZeQJSf04ov1Q8fDjaMUOF 0SGBpfVE112mtCtLrktcX+180KExZPZvK0lf6fbIidy6GxwmSC2ZtPrH+zi+1xNPG73e9yiz ysY1rbbg+af3vJN+fvaIr7L7bZdf5vlq6fcbt/9+K4ysVWIpzkg01GIuKk4EAF3wgldOAgAA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141030_042146_126766_7747D832 X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -5.6 (-----) Cc: Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Chanwoo Choi , Kyungmin Park , Javier Martinez Canillas , Marek Szyprowski X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Minor nit: Initialize the opmode for each regulator to normal mode in a readable explicit way. Signed-off-by: Krzysztof Kozlowski Suggested-by: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas --- drivers/regulator/max77686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c index ac05b318e405..2c276d147c90 100644 --- a/drivers/regulator/max77686.c +++ b/drivers/regulator/max77686.c @@ -473,8 +473,8 @@ static int max77686_pmic_probe(struct platform_device *pdev) struct regulator_dev *rdev; int id = regulators[i].id; - max77686->opmode[id] = regulators[i].enable_mask >> - max77686_get_opmode_shift(id); + max77686->opmode[id] = MAX77686_NORMAL; + rdev = devm_regulator_register(&pdev->dev, ®ulators[i], &config); if (IS_ERR(rdev)) {