| Message ID | 1414668053-31370-2-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Oct 30, 2014 at 12:20:40PM +0100, Krzysztof Kozlowski wrote: > Add of_compatible fields for max77686 and max77802 regulator drivers. > The driver's node should be the same as voltage-regulators node. This > simplifies parsing of regulators init data from DTS. No, this is broken. You're introducing an ABI break that conveys no additional information, I can't see any reason why this should make it simpler to parse init data (you've certainly not articulated one in the changelog here) but even if it did you are changing the ABI incompatibly and convenience isn't a good reason to do that. I'm getting very frustrated with what's going on with these drivers, there seem to be a lot of rather large sets of patches spawning lots of discussion but also frequent review problems and very little actually getting merged (look at the set of changes in the past few merge windows for example). There's something going wrong here.
On pi?, 2014-10-31 at 12:23 +0000, Mark Brown wrote: > On Thu, Oct 30, 2014 at 12:20:40PM +0100, Krzysztof Kozlowski wrote: > > Add of_compatible fields for max77686 and max77802 regulator drivers. > > The driver's node should be the same as voltage-regulators node. This > > simplifies parsing of regulators init data from DTS. > > No, this is broken. You're introducing an ABI break that conveys no > additional information, I can't see any reason why this should make it > simpler to parse init data (you've certainly not articulated one in the > changelog here) but even if it did you are changing the ABI incompatibly > and convenience isn't a good reason to do that. The ABI won't be broken - both drivers would work fine with old and new DTB. However I agree that I should justify this more... Javier and you explained me using parent's device for rdev->dev so I think this change won't be needed and I'll just drop it. Thank you for feedback. > I'm getting very frustrated with what's going on with these drivers, > there seem to be a lot of rather large sets of patches spawning lots of > discussion but also frequent review problems and very little actually > getting merged (look at the set of changes in the past few merge windows > for example). There's something going wrong here. If I over-spammed you, then I am deeply sorry. Best regards, Krzysztof
On Fri, Oct 31, 2014 at 02:07:54PM +0100, Krzysztof Kozlowski wrote: > On pi?, 2014-10-31 at 12:23 +0000, Mark Brown wrote: > > I'm getting very frustrated with what's going on with these drivers, > > there seem to be a lot of rather large sets of patches spawning lots of > > discussion but also frequent review problems and very little actually > > getting merged (look at the set of changes in the past few merge windows > > for example). There's something going wrong here. > If I over-spammed you, then I am deeply sorry. It's not just about volume, it's also about the fact that so little of the mail around these drivers (not just from you) is translating into code that gets merged.
diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index 929795eae9fc..9e1046bdef90 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -38,13 +38,19 @@ #define I2C_ADDR_RTC (0x0C >> 1) static const struct mfd_cell max77686_devs[] = { - { .name = "max77686-pmic", }, + { + .name = "max77686-pmic", + .of_compatible = "maxim,max77686-pmic", + }, { .name = "max77686-rtc", }, { .name = "max77686-clk", }, }; static const struct mfd_cell max77802_devs[] = { - { .name = "max77802-pmic", }, + { + .name = "max77802-pmic", + .of_compatible = "maxim,max77802-pmic", + }, { .name = "max77802-clk", }, { .name = "max77802-rtc", }, };
Add of_compatible fields for max77686 and max77802 regulator drivers. The driver's node should be the same as voltage-regulators node. This simplifies parsing of regulators init data from DTS. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- drivers/mfd/max77686.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)