diff mbox

[V2,4/7] arm64: dts: Add Designware GPIO dts binding to APM X-Gene platform

Message ID 1415924401-3013-5-git-send-email-fkan@apm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Feng Kan Nov. 14, 2014, 12:19 a.m. UTC
Add Designware GPIO dts binding to APM X-Gene platform

Signed-off-by: Feng Kan <fkan@apm.com>
---
 arch/arm64/boot/dts/apm-storm.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Arnd Bergmann Nov. 14, 2014, 3:06 p.m. UTC | #1
On Thursday 13 November 2014 16:19:58 Feng Kan wrote:
> +               dwgpio: dwgpio@1c024000 {
> +                       compatible = "snps,dw-apb-gpio";
> +                       reg = <0x0 0x1c024000 0x0 0x1000>;
> +                       reg-io-width = <4>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> 

Same comment as patch 1: make the node name 'gpio', not 'dwgpio'.

	Arnd
Feng Kan Nov. 14, 2014, 7:26 p.m. UTC | #2
On Fri, Nov 14, 2014 at 7:06 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 13 November 2014 16:19:58 Feng Kan wrote:
>> +               dwgpio: dwgpio@1c024000 {
>> +                       compatible = "snps,dw-apb-gpio";
>> +                       reg = <0x0 0x1c024000 0x0 0x1000>;
>> +                       reg-io-width = <4>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>>
>
> Same comment as patch 1: make the node name 'gpio', not 'dwgpio'.

I can make this change.
>
>         Arnd
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi
index 9a28d3a..35f66fe 100644
--- a/arch/arm64/boot/dts/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm-storm.dtsi
@@ -525,6 +525,21 @@ 
 			interrupts = <0x0 0x4f 0x4>;
 		};
 
+		dwgpio: dwgpio@1c024000 {
+			compatible = "snps,dw-apb-gpio";
+			reg = <0x0 0x1c024000 0x0 0x1000>;
+			reg-io-width = <4>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			porta: gpio-controller@0 {
+				compatible = "snps,dw-apb-gpio-port";
+				gpio-controller;
+				snps,nr-gpios = <32>;
+				reg = <0>;
+			};
+		};
+
 		phy1: phy@1f21a000 {
 			compatible = "apm,xgene-phy";
 			reg = <0x0 0x1f21a000 0x0 0x100>;