| Message ID | 1416823515-9207-1-git-send-email-wens@csie.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 24, 2014 at 06:05:15PM +0800, Chen-Yu Tsai wrote: > The ahb1_sdram clock gate is only used for accessing the sdram > controller's registers over the bus. It is not used for actually clock > the controller or the dram, hence it does not need to be protected. > > This also gets rid of the problem when the protected ahb1_sdram gate > is prepared/enabled while it is still an orphan, and the operation > is not propagated to the correct parent. > > This was confirmed on my A23 tablet and my A31 Hummingbird. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Queued for 3.20, thanks! Maxime
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 337593c..8a38070 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -1425,7 +1425,6 @@ CLK_OF_DECLARE(sun7i_a20_clk_init, "allwinner,sun7i-a20", sun5i_init_clocks); static const char *sun6i_critical_clocks[] __initdata = { "cpu", - "ahb1_sdram", }; static void __init sun6i_init_clocks(struct device_node *node)
The ahb1_sdram clock gate is only used for accessing the sdram controller's registers over the bus. It is not used for actually clock the controller or the dram, hence it does not need to be protected. This also gets rid of the problem when the protected ahb1_sdram gate is prepared/enabled while it is still an orphan, and the operation is not propagated to the correct parent. This was confirmed on my A23 tablet and my A31 Hummingbird. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- drivers/clk/sunxi/clk-sunxi.c | 1 - 1 file changed, 1 deletion(-)