From patchwork Mon Nov 24 19:25:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick X-Patchwork-Id: 5369471 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 945869F39D for ; Mon, 24 Nov 2014 19:27:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BDB76200F2 for ; Mon, 24 Nov 2014 19:27:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82EFD200E9 for ; Mon, 24 Nov 2014 19:27:41 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XszGT-0000QO-EX; Mon, 24 Nov 2014 19:25:37 +0000 Received: from mail-ig0-x22b.google.com ([2607:f8b0:4001:c05::22b]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XszGQ-0000NI-2z for linux-arm-kernel@lists.infradead.org; Mon, 24 Nov 2014 19:25:34 +0000 Received: by mail-ig0-f171.google.com with SMTP id uq10so3702577igb.10 for ; Mon, 24 Nov 2014 11:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=hH3OmT1/yud3BrQBlfvO455LgJOH8JcfrkcmYQaoC3A=; b=ECR+RKrWtUhW8UmFKCBi8HR3XJ3cqyi32jLaON5bJDBHjA6kjYt84Ixv409LMKvxhU abY1UZB4XumJeE8afFV0z45E96blDBkJMd7hX+SWrccj8yfbrIDejaXlhHjr38/Ou4fE /XEIIdox9uJHPNZk/L6WKEbKFVCmkm1k2XIGE6mst6RenjpH7eMYRoKUfsWe/pIjxm1D n/6OJ/rfqNn2xW888eJThg97sqepKUVRWCrwEZ/O4JGFAUxOAWkZAC1cr0eBWsfpwiOn a/t8vfaklaGjCMIjthfdY8r9peDnOMtrg7RBjOVscV7FUcbDi0olC7Tjrf0DbKChT8Cj t49A== X-Received: by 10.107.170.162 with SMTP id g34mr20190746ioj.2.1416857113108; Mon, 24 Nov 2014 11:25:13 -0800 (PST) Received: from nick-System-Product-Name.phub.net.cable.rogers.com (CPE0026f3330aca-CM0026f3330ac6.cpe.net.cable.rogers.com. [99.231.92.7]) by mx.google.com with ESMTPSA id fy5sm4921110igd.3.2014.11.24.11.25.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 24 Nov 2014 11:25:12 -0800 (PST) From: Nicholas Krause To: michal.simek@xilinx.com Subject: [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c Date: Mon, 24 Nov 2014 14:25:08 -0500 Message-Id: <1416857108-2618-1-git-send-email-xerofoify@gmail.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141124_112534_165580_FDFA3A36 X-CRM114-Status: GOOD ( 10.72 ) X-Spam-Score: -0.8 (/) Cc: linux-arm-kernel@lists.infradead.org, soren.brinkmann@xilinx.com, linux-kernel@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits of the bus width and not just the lower or higher 16 depending on the machine's bit order. Signed-off-by: Nicholas Krause Reviewed-by: Michal Simek --- drivers/block/xsysace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c index c4328d9..1b807ed 100644 --- a/drivers/block/xsysace.c +++ b/drivers/block/xsysace.c @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev) static int ace_probe(struct platform_device *dev) { resource_size_t physaddr = 0; - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */ + int bus_width = ACE_BUS_WIDTH_16; u32 id = dev->id; int irq = 0; int i;