| Message ID | 1417906928-5728-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Rickard, On Sunday 07 December 2014 04:32 AM, Rickard Strandqvist wrote: > Remove the function cdce_set_rate() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > arch/arm/mach-davinci/cdce949.c | 37 -------------------------- > arch/arm/mach-davinci/include/mach/cdce949.h | 2 -- > 2 files changed, 39 deletions(-) > > diff --git a/arch/arm/mach-davinci/cdce949.c b/arch/arm/mach-davinci/cdce949.c > index abafb92..bccac4a 100644 > --- a/arch/arm/mach-davinci/cdce949.c > +++ b/arch/arm/mach-davinci/cdce949.c > @@ -212,43 +212,6 @@ static struct cdce_output output_list[] = { > [5] = { cdce_y5_freqs, ARRAY_SIZE(cdce_y5_freqs) }, > }; > > -int cdce_set_rate(struct clk *clk, unsigned long rate) Without this function, this driver is of no use. I can see that CDCE949 support has remained unused for long time. I would rather see the entire support including cdce949.c and cdce949.h and their references removed. Thanks, Sekhar
2015-01-14 11:22 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: > Hi Rickard, > > On Sunday 07 December 2014 04:32 AM, Rickard Strandqvist wrote: >> Remove the function cdce_set_rate() that is not used anywhere. >> >> This was partially found by using a static code analysis program called cppcheck. >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> >> --- >> arch/arm/mach-davinci/cdce949.c | 37 -------------------------- >> arch/arm/mach-davinci/include/mach/cdce949.h | 2 -- >> 2 files changed, 39 deletions(-) >> >> diff --git a/arch/arm/mach-davinci/cdce949.c b/arch/arm/mach-davinci/cdce949.c >> index abafb92..bccac4a 100644 >> --- a/arch/arm/mach-davinci/cdce949.c >> +++ b/arch/arm/mach-davinci/cdce949.c >> @@ -212,43 +212,6 @@ static struct cdce_output output_list[] = { >> [5] = { cdce_y5_freqs, ARRAY_SIZE(cdce_y5_freqs) }, >> }; >> >> -int cdce_set_rate(struct clk *clk, unsigned long rate) > > Without this function, this driver is of no use. I can see that CDCE949 > support has remained unused for long time. I would rather see the entire > support including cdce949.c and cdce949.h and their references removed. > > Thanks, > Sekhar > Hi Sure, sounds nice :) I see if I have time to fix it this weekend. Kind regards Rickard Strandqvist
On Thursday 15 January 2015 04:26 AM, Rickard Strandqvist wrote: > 2015-01-14 11:22 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: >> Hi Rickard, >> >> On Sunday 07 December 2014 04:32 AM, Rickard Strandqvist wrote: >>> Remove the function cdce_set_rate() that is not used anywhere. >>> >>> This was partially found by using a static code analysis program called cppcheck. >>> >>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> >>> --- >>> arch/arm/mach-davinci/cdce949.c | 37 -------------------------- >>> arch/arm/mach-davinci/include/mach/cdce949.h | 2 -- >>> 2 files changed, 39 deletions(-) >>> >>> diff --git a/arch/arm/mach-davinci/cdce949.c b/arch/arm/mach-davinci/cdce949.c >>> index abafb92..bccac4a 100644 >>> --- a/arch/arm/mach-davinci/cdce949.c >>> +++ b/arch/arm/mach-davinci/cdce949.c >>> @@ -212,43 +212,6 @@ static struct cdce_output output_list[] = { >>> [5] = { cdce_y5_freqs, ARRAY_SIZE(cdce_y5_freqs) }, >>> }; >>> >>> -int cdce_set_rate(struct clk *clk, unsigned long rate) >> >> Without this function, this driver is of no use. I can see that CDCE949 >> support has remained unused for long time. I would rather see the entire >> support including cdce949.c and cdce949.h and their references removed. >> >> Thanks, >> Sekhar >> > > Hi > > Sure, sounds nice :) > I see if I have time to fix it this weekend. Okay, I will wait till Monday before preparing my pull requests. Thanks, Sekhar
diff --git a/arch/arm/mach-davinci/cdce949.c b/arch/arm/mach-davinci/cdce949.c index abafb92..bccac4a 100644 --- a/arch/arm/mach-davinci/cdce949.c +++ b/arch/arm/mach-davinci/cdce949.c @@ -212,43 +212,6 @@ static struct cdce_output output_list[] = { [5] = { cdce_y5_freqs, ARRAY_SIZE(cdce_y5_freqs) }, }; -int cdce_set_rate(struct clk *clk, unsigned long rate) -{ - int i, ret = 0; - struct cdce_freq *freq_table = output_list[clk->lpsc].freq_table; - struct cdce_reg *regs = NULL; - - if (!cdce_i2c_client) - return -ENODEV; - - if (!freq_table) - return -EINVAL; - - for (i = 0; i < output_list[clk->lpsc].size; i++) { - if (freq_table[i].frequency == rate / 1000) { - regs = freq_table[i].reglist; - break; - } - } - - if (!regs) - return -EINVAL; - - mutex_lock(&cdce_mutex); - for (i = 0; regs[i].addr; i++) { - ret = i2c_smbus_write_byte_data(cdce_i2c_client, - regs[i].addr | 0x80, regs[i].val); - if (ret) - break; - } - mutex_unlock(&cdce_mutex); - - if (!ret) - clk->rate = rate; - - return ret; -} - static int cdce_probe(struct i2c_client *client, const struct i2c_device_id *id) { diff --git a/arch/arm/mach-davinci/include/mach/cdce949.h b/arch/arm/mach-davinci/include/mach/cdce949.h index c73331f..2280e0b 100644 --- a/arch/arm/mach-davinci/include/mach/cdce949.h +++ b/arch/arm/mach-davinci/include/mach/cdce949.h @@ -14,6 +14,4 @@ #include <mach/clock.h> -int cdce_set_rate(struct clk *clk, unsigned long rate); - #endif
Remove the function cdce_set_rate() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- arch/arm/mach-davinci/cdce949.c | 37 -------------------------- arch/arm/mach-davinci/include/mach/cdce949.h | 2 -- 2 files changed, 39 deletions(-)