From patchwork Wed Dec 10 14:37:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yingjoe Chen X-Patchwork-Id: 5469481 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E2EE99F30B for ; Wed, 10 Dec 2014 14:39:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 23CE22010B for ; Wed, 10 Dec 2014 14:39:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41157200D6 for ; Wed, 10 Dec 2014 14:39:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XyiOb-0006BV-LY; Wed, 10 Dec 2014 14:37:41 +0000 Received: from mailgw02.mediatek.com ([210.61.82.184]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XyiOY-00067p-Bj for linux-arm-kernel@lists.infradead.org; Wed, 10 Dec 2014 14:37:39 +0000 X-Listener-Flag: 11101 Received: from mtkhts09.mediatek.inc [(172.21.101.70)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1927666343; Wed, 10 Dec 2014 22:37:14 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkhts09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 14.3.181.6; Wed, 10 Dec 2014 22:37:13 +0800 Subject: Re: [PATCH 2/4] irqchip: mediatek: Add support for mt8173 From: Yingjoe Chen To: Arnd Bergmann In-Reply-To: <2545975.QDuBFbG7BN@wuerfel> References: <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com> <1418208602-35584-3-git-send-email-eddie.huang@mediatek.com> <2545975.QDuBFbG7BN@wuerfel> Date: Wed, 10 Dec 2014 22:37:13 +0800 Message-ID: <1418222233.21309.17.camel@mtksdaap41> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141210_063738_630660_9A754B32 X-CRM114-Status: GOOD ( 12.97 ) X-Spam-Score: -0.0 (/) Cc: Mark Rutland , devicetree@vger.kernel.org, Jason Cooper , srv_heupstream@mediatek.com, Ian Campbell , Catalin Marinas , Mark Brown , Will Deacon , linux-kernel@vger.kernel.org, Robert Richter , Olof Johansson , Rob Herring , Pawel Moll , Sascha Hauer , Kumar Gala , Matthias Brugger , Thomas Gleixner , Eddie Huang , linux-arm-kernel@lists.infradead.org, yh.chen@mediatek.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Arnd, On Wed, 2014-12-10 at 12:00 +0100, Arnd Bergmann wrote: > On Wednesday 10 December 2014 18:50:00 Eddie Huang wrote: > > From: Yingjoe Chen > > > > MT8173 intpol have 32 more irq pins, add support to it. > > > > Signed-off-by: Yingjoe Chen > > Signed-off-by: Eddie Huang > > > > How about adding a property for the number of irq pins and leave the > old compatible string in place? I don't think it would be good if > we have to update this driver for each new SoC that uses this > irqchip just to change one number. > > Arnd OK, I'll change to something like this in next version: Joe.C --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt @@ -17,12 +17,17 @@ Required properties: use the same interrupt-cells format as GIC. - reg: Physical base address of the intpol registers and length of memory mapped region. +Optional properties: +- mediatek,intpol-number: The number of interrupts supported by intpol, + default 224 if omitted. + Example: sysirq: interrupt-controller@10200100 { compatible = "mediatek,mt6589-sysirq", "mediatek,mt6577-sysirq"; interrupt-controller; #interrupt-cells = <3>; interrupt-parent = <&gic>; reg = <0 0x10200100 0 0x1c>; + mediatek,intpol-number = <224>; };