| Message ID | 1418648413-32013-1-git-send-email-broonie@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 15.12.2014 14:00, Mark Brown wrote: > The Exynos IOMMU driver uses the ARM specific dmac_flush_range() and > outer_flush_range() functions. This breaks the build on arm64 allmodconfig > in -next since support has been merged for some Exynos ARMv8 SoCs. Add a > dependency on ARM to keep things building until either the driver has the > ARM dependencies removed or the ARMv8 architecture code implements these > ARM specific APIs. Hi Mark, Few days ago I posted similar patch: https://lkml.org/lkml/2014/12/5/268 but no one have picked it up. Anyway the fix of yours seems fine to me. Best regards, Krzysztof > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > drivers/iommu/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index 01e8bfae569b..325188eef1c1 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -187,7 +187,7 @@ config TEGRA_IOMMU_SMMU > > config EXYNOS_IOMMU > bool "Exynos IOMMU Support" > - depends on ARCH_EXYNOS > + depends on ARCH_EXYNOS && ARM > select IOMMU_API > select ARM_DMA_USE_IOMMU > help >
On Mon, Dec 15, 2014 at 02:10:37PM +0100, Krzysztof Koz?owski wrote: > Hi Mark, > Few days ago I posted similar patch: > https://lkml.org/lkml/2014/12/5/268 > but no one have picked it up. > Anyway the fix of yours seems fine to me. I don't mind either way, it just seemed to be easier to report the bug with a patch. If Jeorg is busy perhaps it can go via the arm64 tree, the issue is triggered by the addition of the platform there?
On Mon, Dec 15, 2014 at 03:35:29PM +0000, Mark Brown wrote: > On Mon, Dec 15, 2014 at 02:10:37PM +0100, Krzysztof Koz?owski wrote: > > Few days ago I posted similar patch: > > https://lkml.org/lkml/2014/12/5/268 > > but no one have picked it up. > > > Anyway the fix of yours seems fine to me. > > I don't mind either way, it just seemed to be easier to report the bug > with a patch. If Jeorg is busy perhaps it can go via the arm64 tree, > the issue is triggered by the addition of the platform there? Can I pass the buck to arm-soc, as they're handling arm64 platform code? It seems sensible to merge the fix via the same tree that introduced the breakage. Will
On Mon, Dec 15, 2014 at 03:38:04PM +0000, Will Deacon wrote: > On Mon, Dec 15, 2014 at 03:35:29PM +0000, Mark Brown wrote: > > I don't mind either way, it just seemed to be easier to report the bug > > with a patch. If Jeorg is busy perhaps it can go via the arm64 tree, > > the issue is triggered by the addition of the platform there? > Can I pass the buck to arm-soc, as they're handling arm64 platform code? > It seems sensible to merge the fix via the same tree that introduced the > breakage. Sure, just resending to them...
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index 01e8bfae569b..325188eef1c1 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -187,7 +187,7 @@ config TEGRA_IOMMU_SMMU config EXYNOS_IOMMU bool "Exynos IOMMU Support" - depends on ARCH_EXYNOS + depends on ARCH_EXYNOS && ARM select IOMMU_API select ARM_DMA_USE_IOMMU help
The Exynos IOMMU driver uses the ARM specific dmac_flush_range() and outer_flush_range() functions. This breaks the build on arm64 allmodconfig in -next since support has been merged for some Exynos ARMv8 SoCs. Add a dependency on ARM to keep things building until either the driver has the ARM dependencies removed or the ARMv8 architecture code implements these ARM specific APIs. Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/iommu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)