From patchwork Mon Jan 12 19:36:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 5615851 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1C7E19F358 for ; Mon, 12 Jan 2015 19:42:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3B1AE204D8 for ; Mon, 12 Jan 2015 19:42:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31429204CF for ; Mon, 12 Jan 2015 19:42:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YAkov-0002py-BG; Mon, 12 Jan 2015 19:38:37 +0000 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YAkoo-0002gt-JN for linux-arm-kernel@lists.infradead.org; Mon, 12 Jan 2015 19:38:32 +0000 Received: from leverpostej.cambridge.arm.com (leverpostej.cambridge.arm.com [10.1.205.151]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id t0CJb2wq001779; Mon, 12 Jan 2015 19:37:58 GMT From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] arm64: mm: dump: add missing includes Date: Mon, 12 Jan 2015 19:36:48 +0000 Message-Id: <1421091408-10660-3-git-send-email-mark.rutland@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1421091408-10660-1-git-send-email-mark.rutland@arm.com> References: <1421091408-10660-1-git-send-email-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150112_113831_022173_CF9D2404 X-CRM114-Status: GOOD ( 10.63 ) X-Spam-Score: -5.0 (-----) Cc: mark.rutland@arm.com, lauraa@codeaurora.org, keescook@chromium.org, Catalin.Marinas@arm.com, Liviu.Dudau@arm.com, Will.Deacon@arm.com, broonie@kernel.org, steve.capper@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The arm64 dump code is currently relying on some definitions which are pulled in via transitive dependencies. While current build issues have been fixed by a separate patch, it seems we have implicit dependencies on the following definitions: * MODULES_VADDR (asm/memory.h) * MODULES_END (asm/memory.h) * PAGE_OFFSET (asm/memory.h) * PTE_* (asm/pgtable-hwdef.h) * ENOMEM (linux/errno.h) * device_initcall (linux/init.h) This patch ensures we explicitly include the relevant headers for the above items, hopefully preventing future issues as headers are refactored. Signed-off-by: Mark Rutland Reported-by: Mark Brown Cc: Steve Capper Cc: Catalin Marinas Cc: Laura Abbott Cc: Will Deacon --- arch/arm64/mm/dump.c | 4 ++++ 1 file changed, 4 insertions(+) This was previously posted as a standalone patch [1]. As patch 1 fixes the original issue, this patch has been modified to fix the remaining potential issues that we don't yet seem to be hitting. I've also taken Russell's advice to use linux/errno.h. Steve, I've dropped your ack now that the fix for the original issue is in patch 1. Hopefully that's just a formality :) Thanks, Mark. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/315326.html diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c index 203a6cf..48a4a2f 100644 --- a/arch/arm64/mm/dump.c +++ b/arch/arm64/mm/dump.c @@ -14,13 +14,17 @@ * of the License. */ #include +#include #include +#include #include #include #include #include +#include #include +#include #define LOWEST_ADDR (UL(0xffffffffffffffff) << VA_BITS)