From patchwork Thu Jan 15 21:57:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick X-Patchwork-Id: 5642751 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A772A9F357 for ; Thu, 15 Jan 2015 22:00:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E9197201C0 for ; Thu, 15 Jan 2015 22:00:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20358200ED for ; Thu, 15 Jan 2015 22:00:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YBsQd-0008Ra-As; Thu, 15 Jan 2015 21:58:11 +0000 Received: from mail-ie0-x231.google.com ([2607:f8b0:4001:c03::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YBsQY-0008L5-PN for linux-arm-kernel@lists.infradead.org; Thu, 15 Jan 2015 21:58:07 +0000 Received: by mail-ie0-f177.google.com with SMTP id rd18so17484689iec.8 for ; Thu, 15 Jan 2015 13:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=bUvahSP7LsYqhWxa/CdEj06Xsw+fkawMF6IMFTIpWEg=; b=vt2QUkRCqgyOqI/0GwqtJ/BpXRTBCBCOnwV+4Q86n7cRP9EAG2npWPOkM9xt0EabYP KlcJh9TEcK4LR2C1AK9iSq4/McI+Gn79tsN1OlHH1hlCI20P+mygPoKO0TiAkT9GMTZH 3o/MsCyrqzki5z402hnyv2Wd0gtNgT7//H6ZCYs1Ldaw1AGrP3LVbBfwOkpIAqvBr0jE YuIv77ffIO+vuH3B6f+oMkE6nqSplA/z+591773IqDhfamnXEOz20ahBc0dEwxbn42m+ IgJxusQC0wBJyM7SwIe6ps/QhnG4ICtddPodasTnR+1+0bFygke6+32U41t7HfpE/2xP K/rg== X-Received: by 10.50.136.228 with SMTP id qd4mr86132igb.13.1421359063898; Thu, 15 Jan 2015 13:57:43 -0800 (PST) Received: from nick-System-Product-Name.phub.net.cable.rogers.com (CPE0026f3330aca-CM0026f3330ac6.cpe.net.cable.rogers.com. [99.231.92.7]) by mx.google.com with ESMTPSA id b7sm284012igx.15.2015.01.15.13.57.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Jan 2015 13:57:42 -0800 (PST) From: Nicholas Krause To: michal.simek@xilinx.com Subject: [PATCH] block:Remove no longer needed fix me comment in the function, ace_probe for the file, xsysace.c Date: Thu, 15 Jan 2015 16:57:37 -0500 Message-Id: <1421359057-21789-1-git-send-email-xerofoify@gmail.com> X-Mailer: git-send-email 2.1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150115_135806_921725_AFAD8BD6 X-CRM114-Status: GOOD ( 10.37 ) X-Spam-Score: -0.8 (/) Cc: linux-arm-kernel@lists.infradead.org, soren.brinkmann@xilinx.com, linux-kernel@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This removes the no longer needed fix me comment for hardcoding the variable bus_width to the marco,ACE_BUS_WIDTH_16 as unless checked by a if statement inside the function,ace_probe for 8 bit mode the bus width must be 16 bit for this particular function. Signed-off-by: Nicholas Krause --- drivers/block/xsysace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c index c4328d9..1b807ed 100644 --- a/drivers/block/xsysace.c +++ b/drivers/block/xsysace.c @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev) static int ace_probe(struct platform_device *dev) { resource_size_t physaddr = 0; - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */ + int bus_width = ACE_BUS_WIDTH_16; u32 id = dev->id; int irq = 0; int i;