From patchwork Tue Jan 20 07:09:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Perier X-Patchwork-Id: 5665421 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CB132C058D for ; Tue, 20 Jan 2015 07:13:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 57878203AF for ; Tue, 20 Jan 2015 07:13:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99E6E203A9 for ; Tue, 20 Jan 2015 07:13:01 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YDSxh-0006N1-2s; Tue, 20 Jan 2015 07:10:53 +0000 Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YDSwx-0004NG-5R; Tue, 20 Jan 2015 07:10:07 +0000 Received: by mail-wg0-f47.google.com with SMTP id n12so5394025wgh.6; Mon, 19 Jan 2015 23:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ar2m3qYlCPg7jLI+c9ZSiZzwVRFxp5xHuZRtH8eckl8=; b=jklELFV/TJvyKWMvOF9WHsoxuXrWOP1yh7bVsyancJjrtKPn1cb5DQ5fBo3sLxXymm Pee1KwOUxRFDxsezCYe60BNxbpzPOlTZJw1gRg//2mK941EzBWku6t6dv/Ob3+h299ZI ZITvuYYtX25Dma25fOoieeH/8FrU2n/m9cxDNpJZYGbRPc54k6DdurQPPRyQjkTA+ovt 6dTVLnn7WB3NBx2sAfpSvuubkmz3HsGFLPKkvfl46SZy2g6gB0D+G3yXnPTqSv47SSdU bTNr527dEh1wkVkY6t36nU3FDUrqZ06nNraw92ZlvH8IgiScRdqbILGl4UvHFc9kXdqG Kr/w== X-Received: by 10.180.182.72 with SMTP id ec8mr3156930wic.53.1421737784949; Mon, 19 Jan 2015 23:09:44 -0800 (PST) Received: from localhost.localdomain (AToulouse-554-1-139-234.w90-60.abo.wanadoo.fr. [90.60.234.234]) by mx.google.com with ESMTPSA id be4sm1772023wib.16.2015.01.19.23.09.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Jan 2015 23:09:44 -0800 (PST) From: Romain Perier To: peppe.cavallaro@st.com Subject: [PATCH v2 1/4] net: stmmac: dwmac-rk: Don't set the regulator voltage for phy from the driver Date: Tue, 20 Jan 2015 07:09:37 +0000 Message-Id: <1421737780-1533-2-git-send-email-romain.perier@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1421737780-1533-1-git-send-email-romain.perier@gmail.com> References: <1421737780-1533-1-git-send-email-romain.perier@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150119_231007_410284_71742A5F X-CRM114-Status: UNSURE ( 9.61 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: devicetree@vger.kernel.org, heiko@sntech.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, roger.chen@rock-chips.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As these settings can be directly expressed from devicetree for both fixed regulators and pmic-integrated regulators, it is more standard to set them from dts and let the regulator framework use the right voltage informations when it is used in the driver. Signed-off-by: Romain Perier Tested-by: Heiko Stuebner Reviewed-by: Heiko Stuebner --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 35f9b86..06e1637 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -303,7 +303,6 @@ static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable) } else { if (enable) { if (!regulator_is_enabled(ldo)) { - regulator_set_voltage(ldo, 3300000, 3300000); ret = regulator_enable(ldo); if (ret != 0) dev_err(dev, "%s: fail to enable %s\n",