| Message ID | 1423373126-30024-4-git-send-email-rjui@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Feb 07, 2015 at 09:25:26PM -0800, Ray Jui wrote: > Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep > them disabled there. Individual I2C devices can be enabled in board > specific dts file when I2C slave devices are enabled in the future > > Signed-off-by: Ray Jui <rjui@broadcom.com> > Reviewed-by: Scott Branden <sbranden@broadcom.com> > Reviewed-by: Kevin Cernekee <cernekee@chromium.org> I usually don't take DTS patches. They should go via arm-soc. Please say so if there are reasons I should take them.
On 2/9/2015 4:11 AM, Wolfram Sang wrote: > On Sat, Feb 07, 2015 at 09:25:26PM -0800, Ray Jui wrote: >> Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep >> them disabled there. Individual I2C devices can be enabled in board >> specific dts file when I2C slave devices are enabled in the future >> >> Signed-off-by: Ray Jui <rjui@broadcom.com> >> Reviewed-by: Scott Branden <sbranden@broadcom.com> >> Reviewed-by: Kevin Cernekee <cernekee@chromium.org> > > I usually don't take DTS patches. They should go via arm-soc. Please say > so if there are reasons I should take them. > Okay. I'll send this as an individual patch to arm-soc. Thanks, Ray
Le 09/02/2015 21:24, Ray Jui a écrit : > > > On 2/9/2015 4:11 AM, Wolfram Sang wrote: >> On Sat, Feb 07, 2015 at 09:25:26PM -0800, Ray Jui wrote: >>> Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep >>> them disabled there. Individual I2C devices can be enabled in board >>> specific dts file when I2C slave devices are enabled in the future >>> >>> Signed-off-by: Ray Jui <rjui@broadcom.com> >>> Reviewed-by: Scott Branden <sbranden@broadcom.com> >>> Reviewed-by: Kevin Cernekee <cernekee@chromium.org> >> >> I usually don't take DTS patches. They should go via arm-soc. Please say >> so if there are reasons I should take them. >> > Okay. I'll send this as an individual patch to arm-soc. Could you put in in a branch somewhere on github.comù/cygnus-linus.git so it's easy for me to pull from there? -- Florian
On 2/9/2015 9:34 PM, Florian Fainelli wrote: > Le 09/02/2015 21:24, Ray Jui a écrit : >> >> >> On 2/9/2015 4:11 AM, Wolfram Sang wrote: >>> On Sat, Feb 07, 2015 at 09:25:26PM -0800, Ray Jui wrote: >>>> Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep >>>> them disabled there. Individual I2C devices can be enabled in board >>>> specific dts file when I2C slave devices are enabled in the future >>>> >>>> Signed-off-by: Ray Jui <rjui@broadcom.com> >>>> Reviewed-by: Scott Branden <sbranden@broadcom.com> >>>> Reviewed-by: Kevin Cernekee <cernekee@chromium.org> >>> >>> I usually don't take DTS patches. They should go via arm-soc. Please say >>> so if there are reasons I should take them. >>> >> Okay. I'll send this as an individual patch to arm-soc. > > Could you put in in a branch somewhere on github.comù/cygnus-linus.git > so it's easy for me to pull from there? > -- > Florian > Hi Florian, It's in branch cygnus-i2c-v9. Thanks! Ray
diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi index 5126f9e..ff5fb6a 100644 --- a/arch/arm/boot/dts/bcm-cygnus.dtsi +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi @@ -70,6 +70,26 @@ }; }; + i2c0: i2c@18008000 { + compatible = "brcm,cygnus-iproc-i2c", "brcm,iproc-i2c"; + reg = <0x18008000 0x100>; + #address-cells = <1>; + #size-cells = <0>; + interrupts = <GIC_SPI 85 IRQ_TYPE_NONE>; + clock-frequency = <100000>; + status = "disabled"; + }; + + i2c1: i2c@1800b000 { + compatible = "brcm,cygnus-iproc-i2c", "brcm,iproc-i2c"; + reg = <0x1800b000 0x100>; + #address-cells = <1>; + #size-cells = <0>; + interrupts = <GIC_SPI 86 IRQ_TYPE_NONE>; + clock-frequency = <100000>; + status = "disabled"; + }; + uart0: serial@18020000 { compatible = "snps,dw-apb-uart"; reg = <0x18020000 0x100>;