From patchwork Wed Feb 11 08:42:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongzhou Yang X-Patchwork-Id: 5811181 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D18C7BF440 for ; Wed, 11 Feb 2015 08:49:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0E17D2021B for ; Wed, 11 Feb 2015 08:49:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 348AA20218 for ; Wed, 11 Feb 2015 08:49:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YLSwE-0005Rh-Tq; Wed, 11 Feb 2015 08:46:26 +0000 Received: from [66.228.70.111] (helo=mailgw01.mediatek.com) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YLStK-000215-0S for linux-arm-kernel@lists.infradead.org; Wed, 11 Feb 2015 08:43:27 +0000 X-Listener-Flag: 11101 Received: from mtkcas64.mediatek.inc [(172.29.17.144)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v3.9.11 Build 1106 with TLS) with ESMTP id 732558777; Wed, 11 Feb 2015 03:42:33 -0500 Received: from [172.29.97.100] (172.29.97.100) by MTKCAS64.mediatek.inc (172.29.17.210) with Microsoft SMTP Server id 14.3.181.6; Wed, 11 Feb 2015 03:42:59 -0500 Message-ID: <1423644176.1967.12.camel@mussux00.eus.mediatek.inc> Subject: Re: [PATCH v5 3/5] ARM: mediatek: Add Pinctrl/GPIO driver for mt8135. From: Hongzhou Yang To: Linus Walleij Date: Wed, 11 Feb 2015 00:42:56 -0800 In-Reply-To: References: <1421818097-9281-1-git-send-email-hongzhou.yang@mediatek.com> <1421818097-9281-4-git-send-email-hongzhou.yang@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150211_004326_268083_4EF46432 X-CRM114-Status: GOOD ( 17.46 ) X-Spam-Score: 1.3 (+) Cc: Mark Rutland , maoguang.meng@mediatek.com, Catalin Marinas , alan.cheng@mediatek.com, Russell King , toby.liu@mediatek.com, Grant Likely , "Joe.C" , "devicetree@vger.kernel.org" , Vladimir Murzin , Pawel Moll , Ian Campbell , Jean-Christophe PLAGNIOL-VILLARD , Rob Herring , Matthias Brugger , dandan.he@mediatek.com, huang eddie , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Ashwin Chaugule , Sascha Hauer , Kumar Gala X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 2015-02-10 at 16:17 +0800, Linus Walleij wrote: > On Wed, Jan 21, 2015 at 1:28 PM, Hongzhou Yang > wrote: > > > From: Hongzhou Yang > > > > The mediatek SoCs have GPIO controller that handle both the muxing and GPIOs. > > > > The GPIO controller have pinmux, pull enable, pull select, direction and output high/low control. > > > > This driver include common driver and mt8135 part. > > The common driver include the pinctrl driver and GPIO driver. > > The mt8135 part contain its special device data. > > > > Signed-off-by: Hongzhou Yang > > I have merged this patch for v3.21, except: > > > arch/arm/mach-mediatek/Kconfig | 1 + > (...) > --- a/arch/arm/mach-mediatek/Kconfig > > +++ b/arch/arm/mach-mediatek/Kconfig > > @@ -1,6 +1,7 @@ > > menuconfig ARCH_MEDIATEK > > bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7 > > select ARM_GIC > > + select PINCTRL > > select MTK_TIMER > > help > > Support for Mediatek MT65xx & MT81xx SoCs > > This, which should come in through the ARM SoC tree. It's not > dependent on this series anyway. > > This will appear after the merge window as we start the v3.21 cycle. > > Yours, > Linus Walleij Hi Linus, Due to pinconf relate API changed at kernel-3.20, a build error happened. Do I need to send patch v6? Thanks. if (num_configs) has_config = 1; @@ -716,7 +716,7 @@ int mtk_pctrl_init(struct platform_device *pdev, prop = of_find_property(np, "pins-are-numbered", NULL); if (!prop) { - dev_err(&pdev->dev, "only support pins-are-numbered format\n", ret); + dev_err(&pdev->dev, "only support pins-are-numbered format\n"); return -EINVAL; } Yours, Hongzhou diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 721f429..83f474b --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -391,7 +391,7 @@ static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, return -EINVAL; } - err = pinconf_generic_parse_dt_config(node, &configs, &num_configs); + err = pinconf_generic_parse_dt_config(node, pctldev, &configs, &num_configs);