| Message ID | 1423720903-24806-10-git-send-email-Ying.Liu@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Feb 12, 2015 at 02:01:32PM +0800, Liu Ying wrote: > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > --- > v8->v9: > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. > > v7->v8: > * None. > > v6->v7: > * None. > > v5->v6: > * Address the over 80 characters in one line warning reported by the > checkpatch.pl script. > > v4->v5: > * None. > > v3->v4: > * None. > > v2->v3: > * None. > > v1->v2: > * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function > could be placed at the common DRM MIPI DSI driver. > This patch is newly added. > > include/drm/drm_mipi_dsi.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f1d8d0d..3662021 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -163,6 +163,20 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) > return container_of(dev, struct mipi_dsi_device, dev); > } > > +static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) Kerneldoc seems to be missing for this one. -Daniel > +{ > + switch (fmt) { > + case MIPI_DSI_FMT_RGB888: > + case MIPI_DSI_FMT_RGB666: > + return 24; > + case MIPI_DSI_FMT_RGB666_PACKED: > + return 18; > + case MIPI_DSI_FMT_RGB565: > + return 16; > + } > + return -EINVAL; > +} > + > struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np); > int mipi_dsi_attach(struct mipi_dsi_device *dsi); > int mipi_dsi_detach(struct mipi_dsi_device *dsi); > -- > 2.1.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, Feb 12, 2015 at 10:26:42AM +0100, Daniel Vetter wrote: > On Thu, Feb 12, 2015 at 02:01:32PM +0800, Liu Ying wrote: > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > --- > > v8->v9: > > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. > > > > v7->v8: > > * None. > > > > v6->v7: > > * None. > > > > v5->v6: > > * Address the over 80 characters in one line warning reported by the > > checkpatch.pl script. > > > > v4->v5: > > * None. > > > > v3->v4: > > * None. > > > > v2->v3: > > * None. > > > > v1->v2: > > * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function > > could be placed at the common DRM MIPI DSI driver. > > This patch is newly added. > > > > include/drm/drm_mipi_dsi.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > > index f1d8d0d..3662021 100644 > > --- a/include/drm/drm_mipi_dsi.h > > +++ b/include/drm/drm_mipi_dsi.h > > @@ -163,6 +163,20 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) > > return container_of(dev, struct mipi_dsi_device, dev); > > } > > > > +static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) > > Kerneldoc seems to be missing for this one. I'll add it. Thanks for pointing out this. Regards, Liu Ying > -Daniel > > > +{ > > + switch (fmt) { > > + case MIPI_DSI_FMT_RGB888: > > + case MIPI_DSI_FMT_RGB666: > > + return 24; > > + case MIPI_DSI_FMT_RGB666_PACKED: > > + return 18; > > + case MIPI_DSI_FMT_RGB565: > > + return 16; > > + } > > + return -EINVAL; > > +} > > + > > struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np); > > int mipi_dsi_attach(struct mipi_dsi_device *dsi); > > int mipi_dsi_detach(struct mipi_dsi_device *dsi); > > -- > > 2.1.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Hi, Am Donnerstag, den 12.02.2015, 14:01 +0800 schrieb Liu Ying: > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > --- > v8->v9: > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. I can't test this myself for lack of hardware, but I see no further issues with patches 09 - 13 except for the use of imx_drm_encoder_get_mux_id. I'll either rebase my patches that remove it or fix it up when applying. Thierry, may I take these patches through imx-drm, or would you rather I waited for you to pick up the drm/dsi and drm/bridge patches? regards Philipp
Hi Thierry, 2015-03-03 19:07 GMT+08:00 Philipp Zabel <p.zabel@pengutronix.de>: > Hi, > > Am Donnerstag, den 12.02.2015, 14:01 +0800 schrieb Liu Ying: >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> --- >> v8->v9: >> * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. > > I can't test this myself for lack of hardware, but I see no further > issues with patches 09 - 13 except for the use of > imx_drm_encoder_get_mux_id. I'll either rebase my patches that remove it > or fix it up when applying. > > Thierry, may I take these patches through imx-drm, or would you rather I > waited for you to pick up the drm/dsi and drm/bridge patches? Gentle ping. What's your opinion on the patches Philipp mentioned? Regards, Liu Ying > > regards > Philipp > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, Feb 12, 2015 at 02:01:32PM +0800, Liu Ying wrote: > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > --- > v8->v9: > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. > > v7->v8: > * None. > > v6->v7: > * None. > > v5->v6: > * Address the over 80 characters in one line warning reported by the > checkpatch.pl script. > > v4->v5: > * None. > > v3->v4: > * None. > > v2->v3: > * None. > > v1->v2: > * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function > could be placed at the common DRM MIPI DSI driver. > This patch is newly added. > > include/drm/drm_mipi_dsi.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Acked-by: Thierry Reding <treding@nvidia.com>
diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index f1d8d0d..3662021 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -163,6 +163,20 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) return container_of(dev, struct mipi_dsi_device, dev); } +static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) +{ + switch (fmt) { + case MIPI_DSI_FMT_RGB888: + case MIPI_DSI_FMT_RGB666: + return 24; + case MIPI_DSI_FMT_RGB666_PACKED: + return 18; + case MIPI_DSI_FMT_RGB565: + return 16; + } + return -EINVAL; +} + struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np); int mipi_dsi_attach(struct mipi_dsi_device *dsi); int mipi_dsi_detach(struct mipi_dsi_device *dsi);
Signed-off-by: Liu Ying <Ying.Liu@freescale.com> --- v8->v9: * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. v7->v8: * None. v6->v7: * None. v5->v6: * Address the over 80 characters in one line warning reported by the checkpatch.pl script. v4->v5: * None. v3->v4: * None. v2->v3: * None. v1->v2: * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function could be placed at the common DRM MIPI DSI driver. This patch is newly added. include/drm/drm_mipi_dsi.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)