diff mbox

ARM: dts: Update lid and power pin-functions for exynos5250-spring

Message ID 1424276245-7028-1-git-send-email-afaerber@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Andreas Färber Feb. 18, 2015, 4:17 p.m. UTC 
Configure the pins in external interrupt mode, as done for Snow in
e5e5c6d14e39 ("ARM: dts: Add power and lid GPIO keys pinctrl for
exynos5250-snow").

Reported-by: Kukjin Kim <kgene@kernel.org>
Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree")
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 arch/arm/boot/dts/exynos5250-spring.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Javier Martinez Canillas Feb. 19, 2015, 11:49 a.m. UTC | #1 
Hello Andreas,

On 02/18/2015 05:17 PM, Andreas Färber wrote:
> Configure the pins in external interrupt mode, as done for Snow in
> e5e5c6d14e39 ("ARM: dts: Add power and lid GPIO keys pinctrl for
> exynos5250-snow").
> 
> Reported-by: Kukjin Kim <kgene@kernel.org>
> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree")
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Best regards,
Javier
Andreas Färber March 16, 2015, 2:54 p.m. UTC | #2 
Kukjin,

Am 19.02.2015 um 12:49 schrieb Javier Martinez Canillas:
> Hello Andreas,
> 
> On 02/18/2015 05:17 PM, Andreas Färber wrote:
>> Configure the pins in external interrupt mode, as done for Snow in
>> e5e5c6d14e39 ("ARM: dts: Add power and lid GPIO keys pinctrl for
>> exynos5250-snow").
>>
>> Reported-by: Kukjin Kim <kgene@kernel.org>
>> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree")
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
> 
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Ping?

Regards,
Andreas

> 
> Best regards,
> Javier
kgene@kernel.org March 17, 2015, 4:33 p.m. UTC | #3 
On 03/16/15 23:54, Andreas Färber wrote:
> Kukjin,
> 
> Am 19.02.2015 um 12:49 schrieb Javier Martinez Canillas:
>> Hello Andreas,
>>
>> On 02/18/2015 05:17 PM, Andreas Färber wrote:
>>> Configure the pins in external interrupt mode, as done for Snow in
>>> e5e5c6d14e39 ("ARM: dts: Add power and lid GPIO keys pinctrl for
>>> exynos5250-snow").
>>>
>>> Reported-by: Kukjin Kim <kgene@kernel.org>
>>> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>> Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree")
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>> ---
>>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> Ping?
> 
Thanks, applied.

- Kukjin
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
index c41600e587e0..d075a68ac078 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -482,7 +482,7 @@ 
 
 	power_key_irq: power-key-irq {
 		samsung,pins = "gpx1-3";
-		samsung,pin-function = <0>;
+		samsung,pin-function = <0xf>;
 		samsung,pin-pud = <0>;
 		samsung,pin-drv = <0>;
 	};
@@ -510,7 +510,7 @@ 
 
 	lid_irq: lid-irq {
 		samsung,pins = "gpx3-5";
-		samsung,pin-function = <0>;
+		samsung,pin-function = <0xf>;
 		samsung,pin-pud = <0>;
 		samsung,pin-drv = <0>;
 	};