diff mbox

ARM: socfpga: fix uart DMA binding error

Message ID 1424347672-25075-1-git-send-email-s.trumtrar@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Steffen Trumtrar Feb. 19, 2015, 12:07 p.m. UTC
socfpga.dtsi is missing the DMA channels for the uart nodes.
This will produce the following errors:

	of_dma_request_slave_channel: dma-names property of node '/soc/serial0@ffc02000' missing or empty
	ttyS0 - failed to request DMA

Provide the correct DMA channels to fix this.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boot/dts/socfpga.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

dinguyen@opensource.altera.com Feb. 19, 2015, 5:29 p.m. UTC | #1
On Thu, 19 Feb 2015, Steffen Trumtrar wrote:

> socfpga.dtsi is missing the DMA channels for the uart nodes.
> This will produce the following errors:
> 
> 	of_dma_request_slave_channel: dma-names property of node '/soc/serial0@ffc02000' missing or empty
> 	ttyS0 - failed to request DMA
> 
> Provide the correct DMA channels to fix this.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 252c3d1bda50..9d8760956752 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -713,6 +713,9 @@
>  			reg-shift = <2>;
>  			reg-io-width = <4>;
>  			clocks = <&l4_sp_clk>;
> +			dmas = <&pdma 28>,
> +			       <&pdma 29>;
> +			dma-names = "tx", "rx";
>  		};
>  
>  		uart1: serial1@ffc03000 {
> @@ -722,6 +725,9 @@
>  			reg-shift = <2>;
>  			reg-io-width = <4>;
>  			clocks = <&l4_sp_clk>;
> +			dmas = <&pdma 30>,
> +			       <&pdma 31>;
> +			dma-names = "tx", "rx";
>  		};
>  
>  		rst: rstmgr@ffd05000 {
> -- 
> 2.1.4
> 
> 

Applied to fixes.

BR,
Dinh
diff mbox

Patch

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 252c3d1bda50..9d8760956752 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -713,6 +713,9 @@ 
 			reg-shift = <2>;
 			reg-io-width = <4>;
 			clocks = <&l4_sp_clk>;
+			dmas = <&pdma 28>,
+			       <&pdma 29>;
+			dma-names = "tx", "rx";
 		};
 
 		uart1: serial1@ffc03000 {
@@ -722,6 +725,9 @@ 
 			reg-shift = <2>;
 			reg-io-width = <4>;
 			clocks = <&l4_sp_clk>;
+			dmas = <&pdma 30>,
+			       <&pdma 31>;
+			dma-names = "tx", "rx";
 		};
 
 		rst: rstmgr@ffd05000 {