diff mbox

[RFC,3/4] arm64: add support for memtest

Message ID 1425308145-20769-4-git-send-email-vladimir.murzin@arm.com
State New, archived
Headers show

Commit Message

Vladimir Murzin March 2, 2015, 2:55 p.m. UTC
Add support for memtest command line option.

Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
---
 arch/arm64/mm/init.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Will Deacon March 2, 2015, 6:56 p.m. UTC | #1
On Mon, Mar 02, 2015 at 02:55:44PM +0000, Vladimir Murzin wrote:
> Add support for memtest command line option.
> 
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> ---
>  arch/arm64/mm/init.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index ae85da6..597831b 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -190,6 +190,8 @@ void __init bootmem_init(void)
>  	min = PFN_UP(memblock_start_of_DRAM());
>  	max = PFN_DOWN(memblock_end_of_DRAM());
>  
> +	early_memtest(min << PAGE_SHIFT, max << PAGE_SHIFT);
> +
>  	/*
>  	 * Sparsemem tries to allocate bootmem in memory_present(), so must be
>  	 * done after the fixed reservations.

This is really neat, thanks for doing this Vladimir!

  Acked-by: Will Deacon <will.deacon@arm.com>

For the series, modulo Baruch's comments about Documentation updates.

Will
Vladimir Murzin March 3, 2015, 9:26 a.m. UTC | #2
On 02/03/15 18:56, Will Deacon wrote:
> On Mon, Mar 02, 2015 at 02:55:44PM +0000, Vladimir Murzin wrote:
>> Add support for memtest command line option.
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>> ---
>>  arch/arm64/mm/init.c |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
>> index ae85da6..597831b 100644
>> --- a/arch/arm64/mm/init.c
>> +++ b/arch/arm64/mm/init.c
>> @@ -190,6 +190,8 @@ void __init bootmem_init(void)
>>  	min = PFN_UP(memblock_start_of_DRAM());
>>  	max = PFN_DOWN(memblock_end_of_DRAM());
>>  
>> +	early_memtest(min << PAGE_SHIFT, max << PAGE_SHIFT);
>> +
>>  	/*
>>  	 * Sparsemem tries to allocate bootmem in memory_present(), so must be
>>  	 * done after the fixed reservations.
> 
> This is really neat, thanks for doing this Vladimir!
> 
>   Acked-by: Will Deacon <will.deacon@arm.com>
> 
> For the series, modulo Baruch's comments about Documentation updates.
> 
> Will
> 

Thanks Will! I'll wait for awhile for other comments and repost updated
version.

I wonder which tree it might go?

Thanks
Vladimir

> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 
>
Catalin Marinas March 3, 2015, 2:14 p.m. UTC | #3
On Tue, Mar 03, 2015 at 09:26:58AM +0000, Vladimir Murzin wrote:
> On 02/03/15 18:56, Will Deacon wrote:
> > On Mon, Mar 02, 2015 at 02:55:44PM +0000, Vladimir Murzin wrote:
> >> Add support for memtest command line option.
> >>
> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> >> ---
> >>  arch/arm64/mm/init.c |    2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> >> index ae85da6..597831b 100644
> >> --- a/arch/arm64/mm/init.c
> >> +++ b/arch/arm64/mm/init.c
> >> @@ -190,6 +190,8 @@ void __init bootmem_init(void)
> >>  	min = PFN_UP(memblock_start_of_DRAM());
> >>  	max = PFN_DOWN(memblock_end_of_DRAM());
> >>  
> >> +	early_memtest(min << PAGE_SHIFT, max << PAGE_SHIFT);
> >> +
> >>  	/*
> >>  	 * Sparsemem tries to allocate bootmem in memory_present(), so must be
> >>  	 * done after the fixed reservations.
> > 
> > This is really neat, thanks for doing this Vladimir!
> > 
> >   Acked-by: Will Deacon <will.deacon@arm.com>
> > 
> > For the series, modulo Baruch's comments about Documentation updates.
> 
> Thanks Will! I'll wait for awhile for other comments and repost updated
> version.
> 
> I wonder which tree it might go?

Since it touches mm, x86, arm, arm64, I guess it could go in via the mm
tree (akpm). We could take it via the arm64 tree as well if we have all
the acks in place.
diff mbox

Patch

diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
index ae85da6..597831b 100644
--- a/arch/arm64/mm/init.c
+++ b/arch/arm64/mm/init.c
@@ -190,6 +190,8 @@  void __init bootmem_init(void)
 	min = PFN_UP(memblock_start_of_DRAM());
 	max = PFN_DOWN(memblock_end_of_DRAM());
 
+	early_memtest(min << PAGE_SHIFT, max << PAGE_SHIFT);
+
 	/*
 	 * Sparsemem tries to allocate bootmem in memory_present(), so must be
 	 * done after the fixed reservations.