| Message ID | 1426982418-9649-1-git-send-email-stefan@agner.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Stefan Agner <stefan@agner.ch> [150321 17:00]: > The NULL pointer check for superset->muxnames will always evaluate > true since muxnames is an array within struct omap_mux. Remove the > superfluous check to avoid warnings when using LLVM/clang. > > Signed-off-by: Stefan Agner <stefan@agner.ch> Applying into omap-for-v4.1/fixes-not-urgent thanks. Tony > --- > For the reference, the warning generated by LLVM/clang: > arch/arm/mach-omap2/mux.c:1056:18: warning: address of array > 'superset->muxnames' will always evaluate to 'true' [-Wpointer-bool-conversion] > if (!superset->muxnames || !superset->muxnames[0]) { > ~~~~~~~~~~~^~~~~~~~ > > arch/arm/mach-omap2/mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c > index 78064b0..176eef6 100644 > --- a/arch/arm/mach-omap2/mux.c > +++ b/arch/arm/mach-omap2/mux.c > @@ -1053,7 +1053,7 @@ static void __init omap_mux_init_list(struct omap_mux_partition *partition, > struct omap_mux *entry; > > #ifdef CONFIG_OMAP_MUX > - if (!superset->muxnames || !superset->muxnames[0]) { > + if (!superset->muxnames[0]) { > superset++; > continue; > } > -- > 2.3.3 >
diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index 78064b0..176eef6 100644 --- a/arch/arm/mach-omap2/mux.c +++ b/arch/arm/mach-omap2/mux.c @@ -1053,7 +1053,7 @@ static void __init omap_mux_init_list(struct omap_mux_partition *partition, struct omap_mux *entry; #ifdef CONFIG_OMAP_MUX - if (!superset->muxnames || !superset->muxnames[0]) { + if (!superset->muxnames[0]) { superset++; continue; }
The NULL pointer check for superset->muxnames will always evaluate true since muxnames is an array within struct omap_mux. Remove the superfluous check to avoid warnings when using LLVM/clang. Signed-off-by: Stefan Agner <stefan@agner.ch> --- For the reference, the warning generated by LLVM/clang: arch/arm/mach-omap2/mux.c:1056:18: warning: address of array 'superset->muxnames' will always evaluate to 'true' [-Wpointer-bool-conversion] if (!superset->muxnames || !superset->muxnames[0]) { ~~~~~~~~~~~^~~~~~~~ arch/arm/mach-omap2/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)