From patchwork Fri Mar 27 12:28:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 6106911 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3FD489F399 for ; Fri, 27 Mar 2015 12:54:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 510DC203B8 for ; Fri, 27 Mar 2015 12:54:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65507203AD for ; Fri, 27 Mar 2015 12:54:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YbTWE-0007CY-3J; Fri, 27 Mar 2015 12:37:46 +0000 Received: from mailout4.w1.samsung.com ([210.118.77.14]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YbTNi-0007Ui-MD for linux-arm-kernel@lists.infradead.org; Fri, 27 Mar 2015 12:29:00 +0000 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NLV00H2YEU75070@mailout4.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 27 Mar 2015 12:32:31 +0000 (GMT) X-AuditID: cbfec7f4-b7f126d000001e9a-3f-55154c4901c9 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id D9.3C.07834.94C45155; Fri, 27 Mar 2015 12:25:45 +0000 (GMT) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NLV00I58ENIRF00@eusync3.samsung.com>; Fri, 27 Mar 2015 12:28:33 +0000 (GMT) From: Krzysztof Kozlowski To: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] ARM: EXYNOS: Add missing of_node_put() when parsing power domains Date: Fri, 27 Mar 2015 13:28:25 +0100 Message-id: <1427459305-26625-3-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1427459305-26625-1-git-send-email-k.kozlowski@samsung.com> References: <1427459305-26625-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHJMWRmVeSWpSXmKPExsVy+t/xq7qePqKhBuv28Fr8nXSM3eL1C0OL /sevmS02Pb7GanF51xw2ixnn9zFZrD1yl93i1PXPbA4cHr9/TWL02LSqk81j85J6jysnmlg9 +rasYvT4vEkugC2KyyYlNSezLLVI3y6BK2PVwmmMBSd4Krb09bM1MLZzdTFyckgImEisffWS HcIWk7hwbz0biC0ksJRRomOFZBcjF5DdxyQx4/djZpAEm4CxxOblS9hAEiICXYwSs7b8Butg FljEKLHkojOILSwQLbFibxcTiM0ioCrxp+MaWDOvgLvEwaYrUNvkJE4em8wKYnMKeEjcvbKW EWKzu8S9WbfYJzDyLmBkWMUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kREmZfdjAuPmZ1iFGA g1GJh9fgoHCoEGtiWXFl7iFGCQ5mJRFefhfRUCHelMTKqtSi/Pii0pzU4kOMTBycUg2MbGmv PtfNcHx28Idf48zTB+W/R10355dtlpcMezq/Vm22RvYyG9nz9SuW/Iwrnr5u9g5hd/EK5bM+ TcvVCvewfEq6a8k9+Y1OYdkUz2sfpjWEn4y7ZSzl8L41blaQzLJl05fvSZ1v+lWF1Tbv8x4B 1wU6bIzvU3Qb7YxmseZ/3LS94ovDzSgOJZbijERDLeai4kQAouIf9RECAAA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150327_052858_912091_DC1BDB61 X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -5.0 (-----) Cc: Olof Johansson , Krzysztof Kozlowski , Arnd Bergmann , Marek Szyprowski X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add missing of_node_put() to: 1. Error return path if allocating memory for exynos_pm_domain failed. 2. Second iteration over power domains if a child domain was not present or was incomplete. Signed-off-by: Krzysztof Kozlowski Reported-by: Karol Wrona --- Changes since v1: 1. New patch. --- arch/arm/mach-exynos/pm_domains.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 61c32ccc9f7a..1a90c5da2fd7 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -138,6 +138,7 @@ static __init int exynos4_pm_init_power_domain(void) if (!pd) { pr_err("%s: failed to allocate memory for domain\n", __func__); + of_node_put(np); return -ENOMEM; } @@ -209,15 +210,15 @@ no_clk: args.args_count = 0; child_domain = of_genpd_get_from_provider(&args); if (!child_domain) - continue; + goto next_pd; if (of_parse_phandle_with_args(np, "power-domains", "#power-domain-cells", 0, &args) != 0) - continue; + goto next_pd; parent_domain = of_genpd_get_from_provider(&args); if (!parent_domain) - continue; + goto next_pd; if (pm_genpd_add_subdomain(parent_domain, child_domain)) pr_warn("%s failed to add subdomain: %s\n", @@ -225,6 +226,7 @@ no_clk: else pr_info("%s has as child subdomain: %s.\n", parent_domain->name, child_domain->name); +next_pd: of_node_put(np); }