| Message ID | 1427814488-28467-2-git-send-email-alex.bennee@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> Bring into line with the commentary for the other structures and their > KVM_EXIT_* cases. s/commentary/comments/ in the subject and description. Unless you want to add a lengthy discussion :) > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > > --- > > v2 > - add comments for other exit types > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 8055706..5eedf84 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -226,6 +226,7 @@ struct kvm_run { > __u32 count; > __u64 data_offset; /* relative to kvm_run start */ > } io; > + /* KVM_EXIT_DEBUG */ > struct { > struct kvm_debug_exit_arch arch; > } debug; > @@ -274,6 +275,7 @@ struct kvm_run { > __u32 data; > __u8 is_write; > } dcr; > + /* KVM_EXIT_INTERNAL_ERROR */ > struct { > __u32 suberror; > /* Available with KVM_CAP_INTERNAL_ERROR_DATA: */ > @@ -284,6 +286,7 @@ struct kvm_run { > struct { > __u64 gprs[32]; > } osi; > + /* KVM_EXIT_PAPR_HCALL */ > struct { > __u64 nr; > __u64 ret; Looks good to me. David
On Tue, Mar 31, 2015 at 04:07:59PM +0100, Alex Bennée wrote: > Bring into line with the commentary for the other structures and their > KVM_EXIT_* cases. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > > --- > > v2 > - add comments for other exit types > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 8055706..5eedf84 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -226,6 +226,7 @@ struct kvm_run { > __u32 count; > __u64 data_offset; /* relative to kvm_run start */ > } io; > + /* KVM_EXIT_DEBUG */ > struct { > struct kvm_debug_exit_arch arch; > } debug; > @@ -274,6 +275,7 @@ struct kvm_run { > __u32 data; > __u8 is_write; > } dcr; > + /* KVM_EXIT_INTERNAL_ERROR */ > struct { > __u32 suberror; > /* Available with KVM_CAP_INTERNAL_ERROR_DATA: */ > @@ -284,6 +286,7 @@ struct kvm_run { > struct { > __u64 gprs[32]; > } osi; > + /* KVM_EXIT_PAPR_HCALL */ > struct { > __u64 nr; > __u64 ret; > -- > 2.3.4 > I echo David's commit message tweak, otherwise Reviewed-by: Andrew Jones <drjones@redhat.com>
On Tue, Mar 31, 2015 at 04:07:59PM +0100, Alex Bennée wrote: > Bring into line with the commentary for the other structures and their > KVM_EXIT_* cases. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > > --- > > v2 > - add comments for other exit types > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 8055706..5eedf84 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -226,6 +226,7 @@ struct kvm_run { > __u32 count; > __u64 data_offset; /* relative to kvm_run start */ > } io; > + /* KVM_EXIT_DEBUG */ > struct { > struct kvm_debug_exit_arch arch; > } debug; > @@ -274,6 +275,7 @@ struct kvm_run { > __u32 data; > __u8 is_write; > } dcr; > + /* KVM_EXIT_INTERNAL_ERROR */ > struct { > __u32 suberror; > /* Available with KVM_CAP_INTERNAL_ERROR_DATA: */ > @@ -284,6 +286,7 @@ struct kvm_run { > struct { > __u64 gprs[32]; > } osi; > + /* KVM_EXIT_PAPR_HCALL */ > struct { > __u64 nr; > __u64 ret; > -- > 2.3.4 > I'm fine with this change as it is, but I think it should update the documenation of the kvm_run structure along with it, and in there it seems the debug struct is listed as 'unused'; this should be addressed in this patch set somewhere if we start using this struct? -Christoffer
diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h index 8055706..5eedf84 100644 --- a/include/uapi/linux/kvm.h +++ b/include/uapi/linux/kvm.h @@ -226,6 +226,7 @@ struct kvm_run { __u32 count; __u64 data_offset; /* relative to kvm_run start */ } io; + /* KVM_EXIT_DEBUG */ struct { struct kvm_debug_exit_arch arch; } debug; @@ -274,6 +275,7 @@ struct kvm_run { __u32 data; __u8 is_write; } dcr; + /* KVM_EXIT_INTERNAL_ERROR */ struct { __u32 suberror; /* Available with KVM_CAP_INTERNAL_ERROR_DATA: */ @@ -284,6 +286,7 @@ struct kvm_run { struct { __u64 gprs[32]; } osi; + /* KVM_EXIT_PAPR_HCALL */ struct { __u64 nr; __u64 ret;
Bring into line with the commentary for the other structures and their KVM_EXIT_* cases. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- v2 - add comments for other exit types