diff mbox

[1/2] doc/bindings: Add 'endianess' optional-property for FlexCAN controller

Message ID 1428591087-12831-1-git-send-email-bhupesh.sharma@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

bhupesh.sharma@freescale.com April 9, 2015, 2:51 p.m. UTC
This patch adds 'endianess' as the optional-property for
describing the FlexCAN controller present on various FSL platforms.

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
---
 .../devicetree/bindings/net/can/fsl-flexcan.txt    |    4 ++++
 1 file changed, 4 insertions(+)

Comments

Marc Kleine-Budde April 9, 2015, 2:58 p.m. UTC | #1
On 04/09/2015 04:51 PM, Bhupesh Sharma wrote:
> This patch adds 'endianess' as the optional-property for
> describing the FlexCAN controller present on various FSL platforms.
> 
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
> ---
>  .../devicetree/bindings/net/can/fsl-flexcan.txt    |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index 56d6cc3..0d5e668 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -18,6 +18,10 @@ Optional properties:
>  
>  - xceiver-supply: Regulator that powers the CAN transceiver
>  
> +- little-endian: If the FlexCAN IP on this SoC is little-endian, use
> +                 this property. By default it is assumed that the IP
> +                 is big-endian

Where's the code that's evaluating this property? On ARM little endian
is assumed so far, on powerpc (p1010) it's big endian.

Marc
bhupesh.sharma@freescale.com April 9, 2015, 3:41 p.m. UTC | #2
Hi Marc,

> From: Marc Kleine-Budde [mailto:mkl@pengutronix.de]
> 
> On 04/09/2015 04:51 PM, Bhupesh Sharma wrote:
> > This patch adds 'endianess' as the optional-property for describing
> > the FlexCAN controller present on various FSL platforms.
> >
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> > Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
> > ---
> >  .../devicetree/bindings/net/can/fsl-flexcan.txt    |    4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > index 56d6cc3..0d5e668 100644
> > --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > @@ -18,6 +18,10 @@ Optional properties:
> >
> >  - xceiver-supply: Regulator that powers the CAN transceiver
> >
> > +- little-endian: If the FlexCAN IP on this SoC is little-endian, use
> > +                 this property. By default it is assumed that the IP
> > +                 is big-endian
> 
> Where's the code that's evaluating this property? On ARM little endian is
> assumed so far, on powerpc (p1010) it's big endian.
> 

Here: http://thread.gmane.org/gmane.linux.can/7961

On LS1021A SoC, which is an ARM-v7 based SoC, the FlexCAN IP is big-endian.

Regards,
Bhupesh
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
index 56d6cc3..0d5e668 100644
--- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
+++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
@@ -18,6 +18,10 @@  Optional properties:
 
 - xceiver-supply: Regulator that powers the CAN transceiver
 
+- little-endian: If the FlexCAN IP on this SoC is little-endian, use
+                 this property. By default it is assumed that the IP
+                 is big-endian
+
 Example:
 
 	can@1c000 {