diff mbox

[V3,5/6] dts: msm8974: Add blsp2_bam dma node

Message ID 1428736145-18361-6-git-send-email-sricharan@codeaurora.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sricharan Ramabadhran April 11, 2015, 7:09 a.m. UTC 
Signed-off-by: Sricharan R <sricharan@codeaurora.org>
---
 arch/arm/boot/dts/qcom-msm8974.dtsi | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Sergei Shtylyov April 11, 2015, 10:12 p.m. UTC | #1 
Hello.

On 04/11/2015 10:09 AM, Sricharan R wrote:

> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> ---
>   arch/arm/boot/dts/qcom-msm8974.dtsi | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)

> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index e265ec1..2c26151 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
[...]
> @@ -247,5 +247,15 @@
>   			#address-cells = <1>;
>   			#size-cells = <0>;
>   		};
> +
> +		blsp2_dma: dma@f9944000 {

    The ePAPR standard says that the node name should be "dma-controller", not 
just "dma".

[...]

WBR, Sergei
Sricharan Ramabadhran April 13, 2015, 4:14 a.m. UTC | #2 
Hi,

On 04/12/2015 03:42 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 04/11/2015 10:09 AM, Sricharan R wrote:
>
>> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
>> ---
>>   arch/arm/boot/dts/qcom-msm8974.dtsi | 12 +++++++++++-
>>   1 file changed, 11 insertions(+), 1 deletion(-)
>
>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi
>> b/arch/arm/boot/dts/qcom-msm8974.dtsi
>> index e265ec1..2c26151 100644
>> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> [...]
>> @@ -247,5 +247,15 @@
>>               #address-cells = <1>;
>>               #size-cells = <0>;
>>           };
>> +
>> +        blsp2_dma: dma@f9944000 {
>
>     The ePAPR standard says that the node name should be
> "dma-controller", not just "dma".
>
  Ok, will correct this.

Regards,
  Sricharan
diff mbox

Patch

diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index e265ec1..2c26151 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -1,6 +1,6 @@ 
 /dts-v1/;
 
-#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/clock/qcom,gcc-msm8974.h>
 #include "skeleton.dtsi"
 
@@ -247,5 +247,15 @@ 
 			#address-cells = <1>;
 			#size-cells = <0>;
 		};
+
+		blsp2_dma: dma@f9944000 {
+			compatible = "qcom,bam-v1.4.0";
+			reg = <0xf9944000 0x19000>;
+			interrupts = <GIC_SPI 239 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&gcc GCC_BLSP2_AHB_CLK>;
+			clock-names = "bam_clk";
+			#dma-cells = <1>;
+			qcom,ee = <0>;
+		};
 	};
 };