diff mbox

[1/3] dt/bindings: Add binding for the Raspberry Pi firmware driver

Message ID 1430176449-12322-2-git-send-email-eric@anholt.net (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Anholt April 27, 2015, 11:14 p.m. UTC
Signed-off-by: Eric Anholt <eric@anholt.net>
---
 .../devicetree/bindings/arm/bcm/raspberrypi,firmware.txt   | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt

Comments

Lee Jones April 28, 2015, 9:34 a.m. UTC | #1
On Mon, 27 Apr 2015, Eric Anholt wrote:

> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  .../devicetree/bindings/arm/bcm/raspberrypi,firmware.txt   | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
> new file mode 100644
> index 0000000..a74c966
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
> @@ -0,0 +1,14 @@
> +Raspberry Pi VideoCore firmware driver
> +
> +Required properties:
> +
> +- compatible:	Should be "rasbperrypi,firmware"
> +- mboxes:	Single-entry list which specifies which mailbox controller
> +		  and channel is used.

#power-domain-cells?

> +Example:
> +
> +firmware {
> +	compatible = "rasbperrypi,firmware";
> +	mboxes = <&mailbox 0>
> +};
Stephen Warren April 29, 2015, 1:42 a.m. UTC | #2
On 04/27/2015 05:14 PM, Eric Anholt wrote:

This one really needs a patch description, to indicate what kind of
thing this patch introduces a binding for.

> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt

> +Required properties:
> +
> +- compatible:	Should be "rasbperrypi,firmware"
> +- mboxes:	Single-entry list which specifies which mailbox controller
> +		  and channel is used.

It'd be nice to mention that ../../mailbox/mailbox.txt defines the
semantics of this property.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
new file mode 100644
index 0000000..a74c966
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
@@ -0,0 +1,14 @@ 
+Raspberry Pi VideoCore firmware driver
+
+Required properties:
+
+- compatible:	Should be "rasbperrypi,firmware"
+- mboxes:	Single-entry list which specifies which mailbox controller
+		  and channel is used.
+
+Example:
+
+firmware {
+	compatible = "rasbperrypi,firmware";
+	mboxes = <&mailbox 0>
+};