| Message ID | 1431489174-4479-4-git-send-email-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 13.05.2015 12:52, Anand Moon wrote: > Enable CONFIG_LEDS_GPIO, CONFIG_LEDS_TRIGGERS, CONFIG_LEDS_TRIGGER_HEARTBEAT. 1. Remove the trailing stop (dot) from commit title. 2. Please go back to default length of wrapping commit messages. This one exceeds it. Default is 75 characters so git log or git show output would fit in 80 characters terminal. 3. It would be nice to see here WHY you are enabling these configs (what is the benefit). One sentence would be enough. With these changes you can add my tag: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 300678a..21411c5 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -179,6 +179,9 @@ CONFIG_MMC_SDHCI_S3C_DMA=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y CONFIG_MMC_DW_EXYNOS=y +CONFIG_LEDS_GPIO=y +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_HEARTBEAT=y CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX77686=y CONFIG_RTC_DRV_MAX77802=y
Enable CONFIG_LEDS_GPIO, CONFIG_LEDS_TRIGGERS, CONFIG_LEDS_TRIGGER_HEARTBEAT. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/configs/exynos_defconfig | 3 +++ 1 file changed, 3 insertions(+)