From patchwork Wed May 13 13:50:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Nelson X-Patchwork-Id: 6397241 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 045F1BEEE1 for ; Wed, 13 May 2015 13:57:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 24692203DF for ; Wed, 13 May 2015 13:57:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AB462037C for ; Wed, 13 May 2015 13:57:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YsX7N-0008AS-Sh; Wed, 13 May 2015 13:54:37 +0000 Received: from mail-ig0-x236.google.com ([2607:f8b0:4001:c05::236]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YsX3b-0005F4-FX for linux-arm-kernel@lists.infradead.org; Wed, 13 May 2015 13:50:44 +0000 Received: by igbsb11 with SMTP id sb11so45179250igb.0 for ; Wed, 13 May 2015 06:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=iUa7T8UDbnRxRtuCoV7QmjYh1Nw16mZ3MzxRd4uGSrk=; b=Oe1dm9jgdEfHZBE+M0FNwmG6xZisWmtkgQ5hBaaGfSo4o+tMnjXbQUCcB7ENeYnkOn YjvWfOqpOslLw0wmjPh2DVBDNVe7HDokrSWngfF0/mzxM+Rnmhw6PD2RlRC5zcVMnlE6 2S6mw1BpTZs6QKTynkTbnEt66fIuWDU8hpKrNq9tENrWft73+eOGlBR/+nhTMmik68k7 pgu/3ZAAinQnpMT7bKtCGfcTAUjfqDqOPvEE5DIQ5xF13HcdnewWhoEXhspkRMWY88VV GCAbRLAYFHE4ld0PZjnmcg5WGBamkVC2ewrOlZU2Nxdg0cVAoCQFLsl2EIb+0l10ZfZY Xgxw== X-Received: by 10.107.132.42 with SMTP id g42mr26806154iod.25.1431525021468; Wed, 13 May 2015 06:50:21 -0700 (PDT) Received: from hades.digikey.us ([64.77.213.245]) by mx.google.com with ESMTPSA id o9sm14268305ioe.35.2015.05.13.06.50.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 May 2015 06:50:20 -0700 (PDT) From: Robert Nelson To: tony@atomide.com, devicetree@vger.kernel.org Subject: [PATCH] ARM: dts: am335x-bone* enable pmic-shutdown-controller Date: Wed, 13 May 2015 08:50:01 -0500 Message-Id: <1431525001-5747-1-git-send-email-robertcnelson@gmail.com> X-Mailer: git-send-email 2.1.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150513_065043_605361_F665C54A X-CRM114-Status: UNSURE ( 7.24 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: matthijsvanduin@gmail.com, Johan Hovold , Felipe Balbi , linux-omap@vger.kernel.org, Robert Nelson , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes: http://bugs.elinux.org/issues/143 Commit 672e2b147 which introduced proper shutdown chose to let the PMIC go into sleep-state (aka "RTC-only mode") rather than off-state. This was fine for rev A5 on which that patch was tested, but since then two changes have been made to the power supply scheme: (rev A6) enable of the 3v3b regulator moved from LDO2 to LDO4 (3v3a) side-effect: 3v3b rail remains on in sleep-mode (also in off-mode when battery-powered) (rev A6A) am335x vdds supply moved from LDO3 to LDO1 side-effect: vdds remains supplied in sleep-mode As a result heavy leakage occurs from vdds (directly) and 3v3b (via i/o pins) to the 3v3a. The amount of current depends on external connections, but for example leaving a serial console cable connected in this state resulted in serious violation of am335x absolute maximum ratings, with potential for hardware damage. Reported-by: Matthijs van Duin Tested-by: Matthijs van Duin Signed-off-by: Robert Nelson Cc: Tony Lindgren Cc: Felipe Balbi Cc: Johan Hovold Acked-by: Johan Hovold --- arch/arm/boot/dts/am335x-bone-common.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi index c3255e0..7198b81 100644 --- a/arch/arm/boot/dts/am335x-bone-common.dtsi +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi @@ -223,6 +223,8 @@ /include/ "tps65217.dtsi" &tps { + ti,pmic-shutdown-controller; + regulators { dcdc1_reg: regulator@0 { regulator-name = "vdds_dpr";