diff mbox

[PATCHv2,01/12] arm/arm64: kvm: add missing PSCI include

Message ID 1431945503-6939-2-git-send-email-mark.rutland@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mark Rutland May 18, 2015, 10:38 a.m. UTC 
We make use of the PSCI function IDs, but don't explicitly include the
header which defines them. Relying on transitive header includes is
fragile and will be broken as headers are refactored.

This patch includes the relevant header file directly so as to avoid
future breakage.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
---
 arch/arm/kvm/psci.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Hanjun Guo May 19, 2015, 3:37 a.m. UTC | #1 
On 2015?05?18? 18:38, Mark Rutland wrote:
> We make use of the PSCI function IDs, but don't explicitly include the
> header which defines them. Relying on transitive header includes is
> fragile and will be broken as headers are refactored.
>
> This patch includes the relevant header file directly so as to avoid
> future breakage.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> ---
>   arch/arm/kvm/psci.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/kvm/psci.c b/arch/arm/kvm/psci.c
> index 02fa8ef..7e9398c 100644
> --- a/arch/arm/kvm/psci.c
> +++ b/arch/arm/kvm/psci.c
> @@ -24,6 +24,8 @@
>   #include <asm/kvm_psci.h>
>   #include <asm/kvm_host.h>
>
> +#include <uapi/linux/psci.h>
> +
>   /*
>    * This is an implementation of the Power State Coordination Interface
>    * as described in ARM document number ARM DEN 0022A.

Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
diff mbox

Patch

diff --git a/arch/arm/kvm/psci.c b/arch/arm/kvm/psci.c
index 02fa8ef..7e9398c 100644
--- a/arch/arm/kvm/psci.c
+++ b/arch/arm/kvm/psci.c
@@ -24,6 +24,8 @@ 
 #include <asm/kvm_psci.h>
 #include <asm/kvm_host.h>
 
+#include <uapi/linux/psci.h>
+
 /*
  * This is an implementation of the Power State Coordination Interface
  * as described in ARM document number ARM DEN 0022A.