| Message ID | 1432122101-2233-1-git-send-email-broonie@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 20 May 2015 at 05:41, Mark Brown <broonie@kernel.org> wrote: > It's generally preferred that drivers not print initialisation messages on > startup that don't contain information gained at runtime such as specific > hardware revision information. This provides a small speedup on systems > with serial consoles and keeps the boot less noisy. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > drivers/hwtracing/coresight/coresight-etb10.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c > index 77d0f9c1118d..e34e34b8edfb 100644 > --- a/drivers/hwtracing/coresight/coresight-etb10.c > +++ b/drivers/hwtracing/coresight/coresight-etb10.c > @@ -481,7 +481,6 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) > if (ret) > goto err_misc_register; > > - dev_info(dev, "ETB initialized\n"); Linus Walleij started doing something interesting with the initial printouts [1] and I think this is a better option than not printing anything at all. [1]. https://git.linaro.org/kernel/coresight.git/commitdiff/509133a2715367c2ec9f8026ff55a028d04cdae0?hp=0b81f7e469b846b1b56d19d4f8f1f476943856f6 > return 0; > > err_misc_register: > -- > 2.1.4 >
On Fri, May 22, 2015 at 08:17:21AM -0600, Mathieu Poirier wrote: > Linus Walleij started doing something interesting with the initial > printouts [1] and I think this is a better option than not printing > anything at all. It's definitely better to print information we enumerate from hardware, though I'm not 100% sure if AMBA does the right thing with matching here (most of the buses ignore hardware IDs in favour of DT information if things are bound via DT).
On 22 May 2015 at 10:33, Mark Brown <broonie@kernel.org> wrote: > On Fri, May 22, 2015 at 08:17:21AM -0600, Mathieu Poirier wrote: > >> Linus Walleij started doing something interesting with the initial >> printouts [1] and I think this is a better option than not printing >> anything at all. > > It's definitely better to print information we enumerate from hardware, > though I'm not 100% sure if AMBA does the right thing with matching here > (most of the buses ignore hardware IDs in favour of DT information if > things are bound via DT). AMBA has been done properly - bypassing the initial ID lookup with the "arm,primecell-periphid" binding only prevent the HW from being accessed when the DT is parsed. At driver init time the peripheral ID from the DT is checked against the list of AMBA IDs supported by the driver and fails if a match is not found. One can always force things with the "driver-override" sysfs property but that's another story.
diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index 77d0f9c1118d..e34e34b8edfb 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -481,7 +481,6 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) if (ret) goto err_misc_register; - dev_info(dev, "ETB initialized\n"); return 0; err_misc_register:
It's generally preferred that drivers not print initialisation messages on startup that don't contain information gained at runtime such as specific hardware revision information. This provides a small speedup on systems with serial consoles and keeps the boot less noisy. Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/hwtracing/coresight/coresight-etb10.c | 1 - 1 file changed, 1 deletion(-)