| Message ID | 1432803494-3516-1-git-send-email-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 28.05.2015 17:58, Anand Moon wrote: > Enable regulator for usbdrd3_0 and usbdrd3_1 >>From the schematic pin diagram USB3_0 and USB3_1 > is regulated by LDO9 and LD011. Please reformat statement above to proper sentence(s) without ">" before "From". > > Fix the boot message of failed. > [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree > [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed > [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator > [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree > [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed > [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator > [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree > [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed > [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator > [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree > [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed > > --- > This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq > --- I mentioned this already on previous postings. Let's make an exercise. Please: 1. Save your email as mbox format (from mailer). 2. Go to a GIT repo with kernel and checkout base branch. 3. git am 0001-the-name-of-file.mbox 4. git show Do you see the signed-off-by in commit? The patch itself looks good, thanks for fixing this. Just please fix the issues with commit message. By the way: 1. The always-on from LDO9 could be probably removed if the ehci-exynos driver had regulator consumer implemented. 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt) should proably mention the vdd-supply property. Best regards, Krzysztof
Hi Krzysztof, I will take care of these issue in the future. -Anand Moon On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 28.05.2015 17:58, Anand Moon wrote: >> Enable regulator for usbdrd3_0 and usbdrd3_1 >>>From the schematic pin diagram USB3_0 and USB3_1 >> is regulated by LDO9 and LD011. > > Please reformat statement above to proper sentence(s) without ">" before > "From". > >> >> Fix the boot message of failed. >> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree >> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed >> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator >> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree >> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed >> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator >> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree >> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed >> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator >> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree >> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed >> >> --- >> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq >> --- > > I mentioned this already on previous postings. Let's make an exercise. > Please: > 1. Save your email as mbox format (from mailer). > 2. Go to a GIT repo with kernel and checkout base branch. > 3. git am 0001-the-name-of-file.mbox > 4. git show > > Do you see the signed-off-by in commit? > > The patch itself looks good, thanks for fixing this. Just please fix the > issues with commit message. > > By the way: > 1. The always-on from LDO9 could be probably removed if the ehci-exynos > driver had regulator consumer implemented. > 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt) > should proably mention the vdd-supply property. > > Best regards, > Krzysztof > >
On 28.05.2015 19:28, Anand Moon wrote: > Hi Krzysztof, > > I will take care of these issue in the future. Thanks. I just found that prefix ">" was added by my email client so never mind about that but still please write proper sentences (ending with full stop). :) Best regards, Krzysztof > > -Anand Moon > > On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: >> On 28.05.2015 17:58, Anand Moon wrote: >>> Enable regulator for usbdrd3_0 and usbdrd3_1 >>> >From the schematic pin diagram USB3_0 and USB3_1 >>> is regulated by LDO9 and LD011. >> >> Please reformat statement above to proper sentence(s) without ">" before >> "From". >> >>> >>> Fix the boot message of failed. >>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree >>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed >>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator >>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree >>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed >>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator >>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree >>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed >>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator >>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree >>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed >>> >>> --- >>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq >>> --- >> >> I mentioned this already on previous postings. Let's make an exercise. >> Please: >> 1. Save your email as mbox format (from mailer). >> 2. Go to a GIT repo with kernel and checkout base branch. >> 3. git am 0001-the-name-of-file.mbox >> 4. git show >> >> Do you see the signed-off-by in commit? >> >> The patch itself looks good, thanks for fixing this. Just please fix the >> issues with commit message. >> >> By the way: >> 1. The always-on from LDO9 could be probably removed if the ehci-exynos >> driver had regulator consumer implemented. >> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt) >> should proably mention the vdd-supply property. >> >> Best regards, >> Krzysztof >> >> >
W dniu 28.05.2015 o 17:58, Anand Moon pisze: > Enable regulator for usbdrd3_0 and usbdrd3_1 > From the schematic pin diagram USB3_0 and USB3_1 > is regulated by LDO9 and LD011. > > Fix the boot message of failed. > [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree > [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed > [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator > [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree > [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed > [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator > [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree > [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed > [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator > [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree > [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed > Tested on Odroid XU3-Lite board: Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 28.05.2015 17:58, Anand Moon wrote: >> Enable regulator for usbdrd3_0 and usbdrd3_1 >>>From the schematic pin diagram USB3_0 and USB3_1 >> is regulated by LDO9 and LD011. > > Please reformat statement above to proper sentence(s) without ">" before > "From". > >> >> Fix the boot message of failed. >> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree >> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed >> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator >> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree >> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed >> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator >> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree >> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed >> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator >> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree >> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed >> >> --- >> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq >> --- > > I mentioned this already on previous postings. Let's make an exercise. > Please: > 1. Save your email as mbox format (from mailer). > 2. Go to a GIT repo with kernel and checkout base branch. > 3. git am 0001-the-name-of-file.mbox > 4. git show > > Do you see the signed-off-by in commit? > > The patch itself looks good, thanks for fixing this. Just please fix the > issues with commit message. > > By the way: > 1. The always-on from LDO9 could be probably removed if the ehci-exynos > driver had regulator consumer implemented. > 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt) > should proably mention the vdd-supply property. Hi Krzysztof, Please find the patch already send by Vivek Gautam <gautam.vivek@samsung.com> which address this issue. http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/266418.html -Anand Moon > > Best regards, > Krzysztof > >
On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 28.05.2015 17:58, Anand Moon wrote: >> Enable regulator for usbdrd3_0 and usbdrd3_1 >>>From the schematic pin diagram USB3_0 and USB3_1 >> is regulated by LDO9 and LD011. > > Please reformat statement above to proper sentence(s) without ">" before > "From". > >> >> Fix the boot message of failed. >> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree >> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed >> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator >> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree >> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed >> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator >> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree >> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed >> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator >> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree >> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed >> >> --- >> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq >> --- > > I mentioned this already on previous postings. Let's make an exercise. > Please: > 1. Save your email as mbox format (from mailer). > 2. Go to a GIT repo with kernel and checkout base branch. > 3. git am 0001-the-name-of-file.mbox > 4. git show > > Do you see the signed-off-by in commit? > > The patch itself looks good, thanks for fixing this. Just please fix the > issues with commit message. > > By the way: > 1. The always-on from LDO9 could be probably removed if the ehci-exynos > driver had regulator consumer implemented. > 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt) > should proably mention the vdd-supply property. Hi Krzysztof, https://patchwork.kernel.org/patch/4420061/ https://patchwork.kernel.org/patch/4420071/ These patch are missing for this changes to make it work correctly. Can you share you thought on this. -Anand Moon > Best regards, > Krzysztof > >
2015-05-30 22:53 GMT+09:00 Anand Moon <linux.amoon@gmail.com>: > On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: >> On 28.05.2015 17:58, Anand Moon wrote: >>> Enable regulator for usbdrd3_0 and usbdrd3_1 >>>>From the schematic pin diagram USB3_0 and USB3_1 >>> is regulated by LDO9 and LD011. >> >> Please reformat statement above to proper sentence(s) without ">" before >> "From". >> >>> >>> Fix the boot message of failed. >>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree >>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed >>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator >>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree >>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed >>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator >>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree >>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed >>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator >>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree >>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed >>> >>> --- >>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq >>> --- >> >> I mentioned this already on previous postings. Let's make an exercise. >> Please: >> 1. Save your email as mbox format (from mailer). >> 2. Go to a GIT repo with kernel and checkout base branch. >> 3. git am 0001-the-name-of-file.mbox >> 4. git show >> >> Do you see the signed-off-by in commit? >> >> The patch itself looks good, thanks for fixing this. Just please fix the >> issues with commit message. >> >> By the way: >> 1. The always-on from LDO9 could be probably removed if the ehci-exynos >> driver had regulator consumer implemented. >> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt) >> should proably mention the vdd-supply property. > > Hi Krzysztof, > > https://patchwork.kernel.org/patch/4420061/ > https://patchwork.kernel.org/patch/4420071/ > > These patch are missing for this changes to make it work correctly. > > Can you share you thought on this. They look quite old, it is a pity that they were not merged. Best regards, Krzysztof
On 30 May 2015 at 19:23, Anand Moon <linux.amoon@gmail.com> wrote: > On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: >> On 28.05.2015 17:58, Anand Moon wrote: >>> Enable regulator for usbdrd3_0 and usbdrd3_1 >>>>From the schematic pin diagram USB3_0 and USB3_1 >>> is regulated by LDO9 and LD011. >> >> Please reformat statement above to proper sentence(s) without ">" before >> "From". >> >>> >>> Fix the boot message of failed. >>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree >>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed >>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator >>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree >>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed >>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator >>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree >>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed >>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator >>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree >>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed >>> >>> --- >>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq >>> --- >> >> I mentioned this already on previous postings. Let's make an exercise. >> Please: >> 1. Save your email as mbox format (from mailer). >> 2. Go to a GIT repo with kernel and checkout base branch. >> 3. git am 0001-the-name-of-file.mbox >> 4. git show >> >> Do you see the signed-off-by in commit? >> >> The patch itself looks good, thanks for fixing this. Just please fix the >> issues with commit message. >> >> By the way: >> 1. The always-on from LDO9 could be probably removed if the ehci-exynos >> driver had regulator consumer implemented. >> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt) >> should proably mention the vdd-supply property. > > Hi Krzysztof, > > https://patchwork.kernel.org/patch/4420061/ > https://patchwork.kernel.org/patch/4420071/ > > These patch are missing for this changes to make it work correctly. > > Can you share you thought on this. > > -Anand Moon > >> Best regards, >> Krzysztof >> >> Hi Krzysztof Do you want me to resend this. Along with above. https://patchwork.kernel.org/patch/4420061/ https://patchwork.kernel.org/patch/4420071/ -Anand Moon
2015-06-07 11:50 GMT+09:00 Anand Moon <linux.amoon@gmail.com>: > > Hi Krzysztof > > Do you want me to resend this. Along with above. > > https://patchwork.kernel.org/patch/4420061/ > https://patchwork.kernel.org/patch/4420071/ If Vivek is not planning to continue to work on them then sure, please take care of them and resend. Then I'll review them. If you have any other patches which were not applied recently, then please rebase and resend. There were some changes in Odroid DTS. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts index 27014bb..a353a58 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts @@ -513,3 +513,13 @@ &usbdrd_dwc3_1 { dr_mode = "otg"; }; + +&usbdrd3_0 { + vdd33-supply = <&ldo9_reg>; + vdd10-supply = <&ldo11_reg>; +}; + +&usbdrd3_1 { + vdd33-supply = <&ldo9_reg>; + vdd10-supply = <&ldo11_reg>; +};
Enable regulator for usbdrd3_0 and usbdrd3_1 From the schematic pin diagram USB3_0 and USB3_1 is regulated by LDO9 and LD011. Fix the boot message of failed. [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed --- This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq --- Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)